fix: downgrade elastic-apm-node #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of getting this merged and released soon? |
Julusian
added a commit
to nrkno/sofie-core
that referenced
this pull request
Feb 20, 2023
uses a fork of `meteor-elastic-apm` until the PR is merged upstream. Meteor-Community-Packages/meteor-elastic-apm#77
Julusian
added a commit
to nrkno/sofie-core
that referenced
this pull request
Feb 20, 2023
uses a fork of `meteor-elastic-apm` until the PR is merged upstream. Meteor-Community-Packages/meteor-elastic-apm#77
Julusian
added a commit
to nrkno/sofie-core
that referenced
this pull request
Feb 20, 2023
uses a fork of `meteor-elastic-apm` until the PR is merged upstream. Meteor-Community-Packages/meteor-elastic-apm#77
StorytellerCZ
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use v2.5.1 of this package in Meteor 2.5-2.7 (other versions are untested) results in the application crashing when it tries to send a trace, as it attempts to use some wasm.
This pins elastic-apm-node to the newest version that does not attempt to pull in any wasm. Pinning to an old version of the library isn't the best solution, but I don't have any other good ideas that arent a significant amount of work.
When Meteor 3 comes around, this issue will most likely disappear on its own so its probably not worth spending much time on before then