Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: [DX-1992] Fix publish workflow #639

Merged
merged 1 commit into from
Jul 16, 2024
Merged

ci: [DX-1992] Fix publish workflow #639

merged 1 commit into from
Jul 16, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jul 12, 2024 •
edited
Loading

Summary

  • added flutter to the workflow.

Because of the dart-lang/setup-dart#68 you either have to skip all validations or add flutter and run publish via flutter not dart.

Testing steps

I will create a new release and see if it will solve the problem.

Follow-up issues

None.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review July 15, 2024 10:32
@witwash witwash requested a review from a team as a code owner July 15, 2024 10:32
@witwash witwash merged commit ec336a4 into master Jul 16, 2024
8 checks passed
@witwash witwash deleted the fix-publish branch July 16, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil