Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-2141] Migrate to Widgetbook #669

Merged
merged 8 commits into from
Sep 16, 2024
Merged

feat: [DX-2141] Migrate to Widgetbook #669

merged 8 commits into from
Sep 16, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Sep 2, 2024 •
edited
Loading

Summary

  • the first part of migrate from storybook_flutter to widgetbook

This is the initial PR with a few stories. The rest of the migration will be in the following-up PRs

Testing steps

Launch optimus_widgetbook and test the new widgetbook's functionality.

Follow-up issues

  • Adding the rest of the use cases
  • Updating the firebase publishing action

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash changed the title DX-2141 feat: [DX-2141] Migrate to Widgetbook Sep 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

⛔ PR has more than 500 additions. Split it into smaller PRs.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

⛔ PR has more than 500 additions. Split it into smaller PRs.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

⛔ PR has more than 500 additions. Split it into smaller PRs.

@witwash
Copy link
Contributor Author

witwash commented Sep 6, 2024

Pipelines are failing because of the new Flutter version requirement. Waiting for the #674 to be merged

@witwash witwash added the ignore-size Ignore the size of this PR label Sep 6, 2024
@witwash witwash marked this pull request as ready for review September 6, 2024 12:06
@witwash witwash requested a review from a team as a code owner September 6, 2024 12:06
@witwash
Copy link
Contributor Author

witwash commented Sep 11, 2024

@chaeMil 👀

@chaeMil
Copy link
Contributor

chaeMil commented Sep 13, 2024

i know i know...

@witwash witwash merged commit 7b98164 into master Sep 16, 2024
9 checks passed
@witwash witwash deleted the DX-2141 branch September 16, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
ignore-size Ignore the size of this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil