Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DX-2168] Improve password StatusBar transition animation #677

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Sep 15, 2024

Summary

  • improved transition from color to transparency

Testing steps

Dev-tested

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review September 16, 2024 07:44
@witwash witwash requested a review from a team as a code owner September 16, 2024 07:44
@witwash
Copy link
Contributor Author

witwash commented Oct 1, 2024

@chaeMil, can you look at this one? When you go to Color.transparent the animation is not fluid because the transparent color is derived from black. This change will make the transition smooth, because it would use the previous state color and add alpha, instead of the whole color -> transparent transition.

@witwash witwash merged commit b471b32 into master Oct 1, 2024
7 checks passed
@witwash witwash deleted the DX-2168 branch October 1, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants