Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [DX-2180] Fix dialog border #679

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: [DX-2180] Fix dialog border #679

merged 1 commit into from
Sep 19, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Sep 15, 2024

Summary

  • fixed double border bug
  • migrated to new colors

Testing steps

  1. Open Dialog story
  2. Test component using exposed knowbs

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review September 16, 2024 07:44
@witwash witwash requested a review from a team as a code owner September 16, 2024 07:44
@witwash witwash merged commit 60f16ec into master Sep 19, 2024
7 checks passed
@witwash witwash deleted the DX-2180 branch September 19, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil