Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Bump publish action Flutter version #685

Merged
merged 1 commit into from
Sep 24, 2024
Merged

ci: Bump publish action Flutter version #685

merged 1 commit into from
Sep 24, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Sep 24, 2024 •
edited
Loading

Summary

  • fixed outdated Flutter version in publish action

Testing steps

Not needed

Follow-up issues

  • create a variable or something that would ensure all versions are in sync and this won't happen again

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review September 24, 2024 10:55
@witwash witwash requested a review from a team as a code owner September 24, 2024 10:55
@witwash witwash enabled auto-merge (squash) September 24, 2024 13:01
@witwash
Copy link
Contributor Author

witwash commented Sep 24, 2024

@chaeMil 🙏

@witwash witwash merged commit 149f6a2 into master Sep 24, 2024
8 checks passed
@witwash witwash deleted the fix-publish branch September 24, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeMil chaeMil chaeMil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @chaeMil