Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DX-2293] Update rules #690

Merged
merged 2 commits into from
Oct 1, 2024
Merged

feat: [DX-2293] Update rules #690

merged 2 commits into from
Oct 1, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Oct 1, 2024 •
edited
Loading

Summary

Added 2 new rules:

Testing steps

None

Follow-up issues

None

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash marked this pull request as ready for review October 1, 2024 12:19
@witwash witwash requested a review from a team as a code owner October 1, 2024 12:19
@witwash witwash requested a review from ookami-kb October 1, 2024 12:19
@witwash witwash merged commit ba0c400 into master Oct 1, 2024
8 checks passed
@witwash witwash deleted the DX-2293 branch October 1, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@witwash @ookami-kb