Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: [DX-3555] Add Azure cleanup workflow #712

Merged
merged 1 commit into from
Dec 5, 2024
Merged

ci: [DX-3555] Add Azure cleanup workflow #712

merged 1 commit into from
Dec 5, 2024

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Dec 5, 2024

Summary

We've uploaded everything into the root blob folder (the root of mews-ui-widgetbook), but it had to be in the release folder, so the Web app can work correctly.
Doing anything without credentials requires a bunch of requests etc, product-engineering recommended me to clean it up using the workflow and credentials they've provided.

To be safe, it is a dry run, I'll create a new one if deleting with the dry run is successful.

Testing steps

We merge, and I run. Maybe will need to change the trigger, because there are some limitations about what branch Azure is accessible to us.

Follow-up issues

Remove -dryrun and do the cleanup.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested a review from a team as a code owner December 5, 2024 12:59
@witwash witwash merged commit 1f90737 into master Dec 5, 2024
7 checks passed
@witwash witwash deleted the DX-3555 branch December 5, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants