change shell.nix #41
Closed
change shell.nix #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to use `normal user` here because than uid's from this service can collide with other users added with static uids added in nixos configuration. Also normal users would show up in login dialogs like gdm/lightdm.
Like in the borg-job systemd service, env var values are now passed verbatim to the borg process. Previously, the var values were evaluated as bash double quoted strings.
this is nicer because than the other socat command can be also started after the nixos test.
mkpath is a legacy interface.
this is not best practice perl since a long time.
We were using this option in different places. Let's just make it an option so it can be also disabled, as well as makeing sure we have good defaults. By default we will only change the baud rate to 115200, as the default one is 9600, which is uncommon these days. We do not specify --unit=0 as grub will use ACPI to find the serial port configured in the BIOS.
When using disko, the user can choose their own filesystem layout. In that case we don't want to specify fileSystems with normal priority as it would not allow disko to set its own values.
This reverts commit 22e8fd66cf4975cdd1a92202b8cc53a5509cbc1d.
other parts of the ecosystem run after the user activation script to set up permissions. They now instead need to run after the systemd-sysusers.service, which they commonly only do if stage1 systemd is enabled. Since all the tests currently enable stage1 systemd, this now explicitly enforce that users have this set.
This reverts commit 6306bf7.
Aliases do not add new packages, so basic evaluation with nix-env should be enough and fairly quick.
saves a bit of CI time
13 tasks
github-actions
bot
force-pushed
the
main
branch
from
a2ab766 to
ee03bf8
Compare
Mic92
force-pushed
the
main
branch
2 times, most recently
from
7f1ab0c to
69d855f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.