Better Types #74
Merged
Better Types #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged with main to update. New PubTypes file for those that want it. Removed a lot of unnecessary code and organised files around.
Renamed all ChildAdded and ChildDiscarded arguments to be 'thisChild'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better Types
Redesigned the types to create a unique one for each widget containing only the necessary arguments and properties. Added generic type support to State widgets which should make it clearer to use.
This may be inconvenient to have a type for every widget, but it should make Iris easier to use with intellisense which is one of the biggest issues I here of.
Additions
Changes
Fixes