Add directives support to Interfaces #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
=======================================
Coverage 95.34% 95.35%
=======================================
Files 80 80
Lines 1483 1485 +2
Branches 295 295
=======================================
+ Hits 1414 1416 +2
Misses 66 66
Partials 3 3
Continue to review full report at Codecov.
|
MichalLytek
added
Community 👨👧
|
Sorry @Superd22 for no response for this PR for over 2 months, I've totally forgot about this 😞
I think that's ok. If there will be some use cases for separating interfaces from object types, we can always add some global or scoped config for that 😉 |
MichalLytek
force-pushed
the
feat-interface-directives
branch
from
8bfb3b6 to
5c1a25a
Compare
|
I've added changelog entry and updated docs 😉 Merging 🚀 |
MichalLytek
added a commit
that referenced
this pull request
Jan 4, 2021
Co-authored-by: Michał Lytek <michal.wojciech.lytek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using
@Directiveon InterfaceType (and its fields).Directives are supported on interface as per GraphQL specs and that support is widely implemented, see Apollo for example.
Possible caveats
In this proposed implementation, any ObjectType implementing the interface (more precisely, whose typescript class extends the typescript class of the interface) will inherit its directives. This seems in line with the current behavior of TypeGraphQL.
Nevertheless, as it stands, users would not be able to only add directive to the interface and not the objects implementing it.
I'd love insights about this behavior and if you think that's a problem.