Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow omitting properties in trackEvent call #202

Merged
merged 2 commits into from
Dec 20, 2017
Merged

Allow omitting properties in trackEvent call #202

merged 2 commits into from
Dec 20, 2017

Conversation

bmourat
Copy link
Contributor

@bmourat bmourat commented Dec 19, 2017

This addresses #201

@dhei
Copy link
Member

dhei commented Dec 19, 2017 •
edited
Loading

@bmourat This change looks good. Can you add a UI test to AnalyticsScreen.js of TestApp & TestApp34 something like this:

<TouchableOpacity onPress={() => Analytics.trackEvent('Event without properties')}>
  <Text style={SharedStyles.button}>
    Track Event without properties
  </Text>
</TouchableOpacity>

dhei
dhei suggested changes Dec 19, 2017
View reviewed changes
Copy link
Member

@dhei dhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

@dhei dhei merged commit bdab91c into microsoft:develop Dec 20, 2017
@bmourat bmourat deleted the fix/allow-null-properties branch February 12, 2018 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhei dhei dhei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmourat @dhei