Merge pull request #202 from bmourat/fix/allow-null-properties

Allow omitting properties in trackEvent call
microsoft · Dec 20, 2017 · bdab91c · bdab91c
2 parents 5a35da9 + aae6419
commit bdab91c
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/TestApp/AnalyticsScreen.js b/TestApp/AnalyticsScreen.js
@@ -62,6 +62,12 @@ export default class AnalyticsScreen extends React.Component {
             </Text>
           </TouchableOpacity>
 
+          <TouchableOpacity onPress={() => Analytics.trackEvent('Event without properties')}>
+            <Text style={SharedStyles.button}>
+              Track Event without properties
+            </Text>
+          </TouchableOpacity>
+
           <TouchableOpacity onPress={() => Analytics.trackEvent('Button press', { propertyValueTooLong: '12345678901234567890123456789012345678901234567890123456789012345' })}>
             <Text style={SharedStyles.button}>
               Track Event - event property value truncated after 64 characters

diff --git a/TestApp34/AnalyticsScreen.js b/TestApp34/AnalyticsScreen.js
@@ -62,6 +62,12 @@ export default class AnalyticsScreen extends React.Component {
             </Text>
           </TouchableOpacity>
 
+          <TouchableOpacity onPress={() => Analytics.trackEvent('Event without properties')}>
+            <Text style={SharedStyles.button}>
+              Track Event without properties
+            </Text>
+          </TouchableOpacity>
+
           <TouchableOpacity onPress={() => Analytics.trackEvent('Button press', { propertyValueTooLong: '12345678901234567890123456789012345678901234567890123456789012345' })}>
             <Text style={SharedStyles.button}>
               Track Event - event property value truncated after 64 characters

diff --git a/appcenter-analytics/Analytics.js b/appcenter-analytics/Analytics.js
@@ -19,10 +19,13 @@ module.exports = {
     }
 };
 
-function sanitizeProperties(props) {
+function sanitizeProperties(props = null) {
     // Only string:string mappings are supported currently.
 
     const result = {};
+    if (props === null) {
+        return result;
+    }
     Object.keys(props).forEach((key) => {
         switch (typeof props[key]) {
             case 'string':