Fix recursive header expansion error #290
Conversation
|
@bmourat VSTS build (https://msmobilecenter.visualstudio.com/_permalink/_build/index?collectionId=27bf89de-9697-418a-accf-1aa125b22914&projectId=c5683969-a866-4281-b5c4-3a18f2414bc6&buildId=153026) failed probably because there's a release in flight and the npm version not yet exist. Just wait a bit and trigger the build again after the release. |
|
@dhei thanks! |
| "$(SRCROOT)/../../react-native/React/Base", | ||
| "$(SRCROOT)/../../react-native/React/Modules", | ||
| "$(SRCROOT)/../../react-native/React/CSSLayout", | ||
| "$(SRCROOT)/../../react-native/React/Views", |
There was a problem hiding this comment.
Adding "$(SRCROOT)/../../../ios/Pods/Headers/Public/React/**" or non recursive variants would solve issues where React is added via CocoaPods
|
Once #296 is merged, the Eslint error should go away. |
| "$(inherited)", | ||
| ); | ||
| HEADER_SEARCH_PATHS = "$(SRCROOT)/../../react-native/React/**"; | ||
| HEADER_SEARCH_PATHS = ( | ||
| "$(SRCROOT)/../../react-native/React/Base", |
There was a problem hiding this comment.
Why narrowing down the header search paths from ** to 4 specific modules?
There was a problem hiding this comment.
We can't have recursive at root as it causes #246. So we try to limit to what we need.
|
Hi @bmourat, please verify react-native link on TestApp and blank new RN app. I will merge it once it's verified. |
Fixes #246