Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive header expansion when using other libs such as Firebase #246

Closed
ethanyuwang opened this issue Feb 21, 2018 · 24 comments
Closed

Recursive header expansion when using other libs such as Firebase #246

ethanyuwang opened this issue Feb 21, 2018 · 24 comments
Labels

Comments

@ethanyuwang
Copy link

ethanyuwang commented Feb 21, 2018

I installed AppCenter and CodePush as instructed. When I tried to compile I encountered this error:

Showing Recent Issues
Argument list too long: recursive header expansion failed at /Users/ethanwang/Github/reactnative/Glever_RNI/Glever/node_modules/appcenter/ios/../../../ios/Pods/React/node_modules/fsevents/node_modules/har-validator/lib/node6.

Enviroment:

"react-native": "0.53.0",
node: v8.9.4
cocoapods-1.4.0

I have looked up this error it seems like it was fixed on V1.20 (#209)

But I'm still experiencing the same error. How should I fix this?

@ElektrojungeAtWork
Copy link
Contributor

Hi @ethanyuwang,

I'd like to help you with this. The title of this issue (still) suggests that you had this issue before? I couldn't find it here on Github, can you point me to it, please?

If this is a new issue, can you please provide more context?

  • RN version
  • Node version (It looks like you are using node 6)
  • Cocoapods version
  • When does the error happen?

@ethanyuwang
Copy link
Author

@TroubleMakerBen Hi, thank you. I have just updated my issue.

@ethanyuwang
Copy link
Author

Any updates on this?

@guperrot
Copy link
Member

guperrot commented Feb 24, 2018

We released cocoapods 1.4.0 support only in our SDK version 1.3.0 and your issue is saying you are using cocoapods 1.4.0.

Can you try on our 1.3.0 SDK?

@guperrot
Copy link
Member

Also we are not compatible with react native 0.53 at the moment. You will have to downgrade temporarily to 0.52 to be able to execute react-native link and then update react again after, sorry for the inconvenience

@BrijeshShiroya
Copy link

I had the same issue. I tried to install npm into another system. But still getting same issue. Can you please help me? What is the exact issue?

@guperrot
Copy link
Member

What versions are you using for our SDK and Cocoapods and react-native.

@dilee716
Copy link

dilee716 commented Feb 27, 2018

I'm having same issues
SDK: 1.3.0
Cocoapods: 1.4.0
react-native: 0.52.1

@guperrot
Copy link
Member

guperrot commented Feb 27, 2018

The header search path for app center should not be recursive:

screen shot 2018-02-27 at 2 34 50 pm

Do you have recursive on appcenter headers?

@dilee716
Copy link

they are not-recursive

@guperrot
Copy link
Member

but is your error about recursive headers like in the first comment or is it another issue? Please share the exact error message.

@dilee716
Copy link

dilee716 commented Feb 28, 2018

error is just like first comment.
Argument list too long: recursive header expansion failed at /Users/dominic/MyAwesomeApp/node_modules/appcenter-analytics/ios/../../../ios/Pods/React/Libraries.

@guperrot
Copy link
Member

This is a really weird error since you don't use recursive header but complains about recursive, I cannot reproduce here. We will need you to share project sources so we can repro.

@dilee716
Copy link

There are some other headers that are recursive. The appcenter headers are not recursive.
screen shot 2018-02-27 at 10 13 00 pm

@guperrot
Copy link
Member

Do you need those to be recursive? Can you share sources please?

@ethanyuwang
Copy link
Author

I'm not very sure if this was the fix since I have tried a lot of different things, but I don't have this error anymore.

Somehow there's another react folder in my pods then I deleted it and included this code in my Podfile:

  pod "yoga", :path => "../node_modules/react-native/ReactCommon/yoga"
  pod 'React', :path => '../node_modules/react-native'

Then when running pod install the pods won't install a react pod inside the Pods folder but instead, they look for the react folder in node_modules.

@guperrot
Copy link
Member

guperrot commented Mar 1, 2018

@ethanyuwang I don't have a React directory in Pods folder though I don't have those lines either. Do you need React as a pod dependency? Anyway deleting React under Pods seems like the right thing to do, not sure about the Podfile part.

@ethanyuwang
Copy link
Author

I think it was needed for react-native-firebase. I did notice pod install would install react-native 0.11 if I don't have that code in my Podfile when I tried to install appcenter

@guperrot
Copy link
Member

guperrot commented Mar 2, 2018

@guperrot
Copy link
Member

guperrot commented Mar 2, 2018

@dilee716 @BrijeshShiroya do you use other 3rd party libs depending on react as pods ? You can look for React in ios/Podfile.lock, if yes you can follow the steps described in #246 (comment) to work around the issue.

@guperrot guperrot changed the title Still having recursive header expansion error on V1.20 Recursive header expansion when using other libs such as Firebase Mar 2, 2018
@guperrot guperrot removed the bug label Mar 2, 2018
@dilee716
Copy link

dilee716 commented Mar 2, 2018

yeah, currently using other 3rd party libs depending on react as pods. Messing around with it right now. thanks for checking in @guperrot

@guperrot guperrot removed the support label Mar 6, 2018
@thebradbain
Copy link

thebradbain commented Apr 7, 2018

Has there been any update on this? Or is this workaround the solution still?

@guperrot
Copy link
Member

guperrot commented Apr 9, 2018

Hi, right now the work around is still needed.

@dhei
Copy link
Member

dhei commented May 17, 2018

As a follow up, v1.5.1 is released today and this issue should be fixed.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants