React/RCTDefines.h not found

[mmiani]

I'm having this issue: React/RCTDefines.h not found after upgrading CocoaPods to v 1.5.3
According to their changelog

CocoaPods will no longer add all header search paths for each xcconfig generated and instead, it only adds the header search paths for the dependencies of the pod.

So I tried adding React as a dependency in the podspec and that fixed the issue

[msftclas]

All CLA requirements met.

[dhei]

Hey @mmiani,

Thanks for the PR.

I just tried react-native link a brand new app created by react-native init to link latest version of appcenter sdk with cocoapods v1.5.3 and I don't see any issues. Can you describe a repro step of this issue?

The PR itself looks fine except it's missing a change in appcenter-analytics/ios/appcenter-push.podspec. Please make sure you also update that file.

[mmiani]

My iOS project is not the standard one created by react-native init.
My problem is that react-native link links the appcenter projects into the project "Libraries folder" but my project consumes dependencies via cocoapods and not project references.
Since your last version (PR), it's possible to use cocoapods without react-native link so I've configured all the appcenter packages via cocoapods. (it would be good to include this case in the documentation)

My pod file looks like this:

pod 'appcenter', path: '../node_modules/appcenter/ios'
pod 'appcenter-analytics', path: '../node_modules/appcenter-analytics/ios'
pod 'appcenter-crashes', path: '../node_modules/appcenter-crashes/ios'

I've added the missing change to appcenter-push, please let me know if you need any further clarification.

[dhei]

@mmiani, I struggled to setup a react native project that neither use "react-native link" or "Libraries folder", but only use cocoapods. My problem is when I removed all references in Libraries folder from Xcode, it doesn't know where to find reference.

Can you share a stripped down version of your RN.iOS app not using "Libraries folder" so that I can reproduce? It could much appreciate to see how to convert a "standard" RN.iOS app create via react-native init to your flavor. Thanks.

[dhei]

@mmiani, a caveat of not using "react-native link": AppCenter SDKs use prompt during "react-native link" to ask for information:

(1) AppSecret which will be recorded in AppCenter-Config.plist;
(2) [AppCenterReactNative register] AppCenter start code in AppDelegate.m.

In other words, without "react-native link", users have to add those code themselves. Basically the last 2 steps from integrate-the-ios-sdk-manually.

But still, I am interested to see what exactly is required to integrate AppCenter SDKs without "react-native link" even with slightly worse user experience.

[mmiani]

Unfortunately, I can't share my iOS project, I'll try to generate a clean iOS project with RN integrated and some dependencies configured via CocoaPods so you can have an idea

[oblador]

I'm having the same issue with a fresh app using the CocoaPods integration mentioned here: https://facebook.github.io/react-native/docs/integration-with-existing-apps

[dhei]

@oblador, have you tried Integrate the iOS SDK manually doc and still having the same issue?

[oblador]

@dhei Try with your own BrownfieldTestApp project to reproduce the issue.

[oblador]

@dhei Did you manage to recreate this using your own example app?

[DulMephistos]

Any updates on this? Having the same issue now with CocoaPods 1.6.0.beta.1

[bmourat]

I've managed to reproduce this, and I can confirm that this PR resolves that issue!