Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File names in extension can no longer contain spaces? #174

Open
jessehouwing opened this issue Nov 20, 2016 · 7 comments
Open

File names in extension can no longer contain spaces? #174

jessehouwing opened this issue Nov 20, 2016 · 7 comments

Comments

@jessehouwing
Copy link

jessehouwing commented Nov 20, 2016

It didn't use to be a problem when packaging extensions, but since 0.3.40 I'm getting the error below:

error: Part Name 'vsts-snyk/node_modules/snyk/Contributor Agreement.md' is invalid. Please check the following: 
error: 1. No whitespace or any of these characters: #^[]<>?
error: 2. Cannot end with a period.
error: 3. No percent-encoded / or \ characters. Additionally, % must be followed by two hex characters.
tfx failed with error: Error: C:\TFS\_W\3\s\node_modules\.bin\tfx.cmd failed with return code: 4294967295

Since I cannot enforce this kind of restriction on developers of 3rd party dependencies, it's a very inconvenient change.

@tomap
Copy link

tomap commented Jan 16, 2017

Hi,

Could you please tell us if this check is here because of a limitation of VSIX or it's something that could be changed ?

Thank you

tomap added a commit to tomap/nsis-extension that referenced this issue Jan 16, 2017
Nsis binaries constains spaces, which are incompatible with VSTS extensions
See microsoft/tfs-cli#174
@rfennell
Copy link

Seeing the same issue, anyone ever get a fix or workaround for this issue?

@jessehouwing
Copy link
Author

jessehouwing commented Jun 29, 2017 via email

@rfennell
Copy link

ouch, loads of .md documention files that come with the 3rd party packages, but i guess i can try that

@rfennell
Copy link

rfennell commented Nov 9, 2017

To get around this problem we have been running an in-line Powershell script prior to running the VSIX packaging step.

The code is as follows

dir -recurse | where {-Not $_.PsIscontainer -AND $_.name -match " "} | foreach { 
    $New=$_.name.Replace(" ","_")
    Rename-Item -path $_.Fullname -newname $New -passthru
}   

@TerrenceHuang
Copy link

same issue too

@simchev
Copy link

simchev commented Oct 30, 2019

Issue still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants