Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #86

Merged
merged 8 commits into from
Mar 16, 2023
Merged

Conversation

frk-dc
Copy link
Contributor

@frk-dc frk-dc commented Mar 9, 2023

Update dependencies

@frk-dc frk-dc requested review from AndKiel and Nikamura March 9, 2023 16:43
AndKiel
AndKiel previously approved these changes Mar 10, 2023
@AndKiel
Copy link
Contributor

AndKiel commented Mar 14, 2023

What's the reason for replacing pino with winston? pino logger is our logger of choice in API team (not sure about others but I think they use pino too).

@frk-dc
Copy link
Contributor Author

frk-dc commented Mar 15, 2023

What's the reason for replacing pino with winston?

azure-pipelines-task-lib no longer supports file names with whitespaces, pino-pretty has a peer dependency on a module that's published with a test file that breaks that rule.
Replacing the logger and matching the format was preferred to keeping an outdated azure-pipelines-task-lib.

@@ -2,7 +2,7 @@
"manifestVersion": 1,
"id": "automator-tools",
"name": "Protect Tools",
"version": "1.0.3",
"version": "1.0.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's already published as 1.1.4?

@frk-dc frk-dc merged commit 4c52233 into master Mar 16, 2023
@frk-dc frk-dc deleted the feat/GA-1517_update_dependencies branch March 16, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants