gocode-gomod daemon stays running after closing VSCode

[ssergiienko]

Steps to Reproduce:

1. Open any Go project with Go modules and use auto-completion feature
2. Close VSCode

Actual result: daemon stays running in your system
Expected: It should be stopped with VSCode like original "gocode" daemon

Go extension v0.7.0

[oneslash]

I was trying to debug it and found this, #2134 it might be related.
What do you think @ramya-rao-a

EDIT: It is not related

[ramya-rao-a]

It should be stopped with VSCode like original "gocode" daemon

The original "gocode" daemon was never stopped either

See #26 (comment)

[ssergiienko]

@ramya-rao-a Don't you think that it's slightly strange to ask users to do manual pkill gocode/gocode-gomod each time after closing IDE? 😕

As a proposed solution for this ticket and for #26 why not just save PID and internal flag "started_by_vscode" and stop daemon on this condition:
if started_by_vscode == True AND pid == saved_pid then stop_daemon().

It's easy to implement and it will work for all cases except for super corner case when User stared VSCode then start another editor which is also use gocode but unable to restart it itself, and then close VSCode.

[ramya-rao-a]

Yes, that can be done.

The trick is to determine if gocode was started by VS Code or not.

When the Go extension deactivates which is when the VS Code window is closed/reloaded, we can add a step that cleans up the running gocode process if it was started by VS Code.

PRs are most welcome if you want to give this a try.

Code Pointers:

• Build and Debug extension
• deactivate() is the place where the cleanup should happen
• https://github.com/Microsoft/vscode-go/blob/0.7.0/src/goSuggest.ts#L225 is where we spawn the process that would start gocode if it isnt already running

[ramya-rao-a]

The fix for this is now out in the latest update to the Go extension (0.8.0)
Thanks @zmb3!