gocode.exe does not close when VS Code exits

[syncore]

On Windows, gocode.exe continues to run even after VS code is completely closed. I am not sure of the behavior on other platforms. Is there a way to automatically close gocode.exe when the editor itself is exited?

[lukehoban]

Yes - we should be invoking gocode close when the extension is deactivated to try and stop the gocode deamon.

[egamma]

just a heads-up, in 0.10.1 a deactivate() function for cleaning-up isn't supported yet.

[lukehoban]

Thanks @egamma - is there an issue already tracking this that we can link here?

I think that means we can't really fix this for now. Will keep this active waiting for the deactivate call to be added in Code.

[egamma]

you could listen on the 'exit' event of the extension host process.

process.on('exit', function(code) {

[lukehoban]

@egamma Unfortunately it doesn't look like that will work - shutting down gocode requires shelling out to gocode close and I'm not seeing that run inside the 'exit' handler. The node.js docs say that you cannot do async work in this handler, which is likely the reason this isn't working?

There is no way to prevent the exiting of the event loop at this point, and once all exit listeners have finished running the process will exit. Therefore you must only perform synchronous operations in this handler.

[egamma]

never tried this, but could spawning another process that runs gocode close work? There is a sync function to spawn a process: childProcess.execSync.

[lukehoban]

I tried that, and it doesn't seem to work either. I also tried just doing a fs.writeFileSync and even that's not working.

[ramya-rao-a]

@lukehoban Correct me if I am wrong, but since gocode is a daemon, if it was already running (say the user was using it independent of VS Code), then VS Code wouldn't start a new process. In this case, closing it when the editor closes wouldnt be the right thing to do.

[ramya-rao-a]

Closing this issue as a "won't fix" because of #26 (comment)