Update packages #2014
Update packages #2014
Conversation
|
|
package.json
Outdated
| "vscode": "^1.1.21" | ||
| }, | ||
| "engines": { | ||
| "vscode": "^1.22.0" | ||
| "vscode": "^1.26.0" |
There was a problem hiding this comment.
Any particular reason for this change?
This change will result in the next update to the Go extension not being available to anyone who is on versions of VS Code older than 1.26.0
There was a problem hiding this comment.
There where typing issues with one of the dependencies with the 1.22 version, I based my solution on this microsoft/language-server-protocol#556 (comment) comment
There was a problem hiding this comment.
In that case, lets not update any of the vscode- dependencies just yet.
I usually prefer to wait till we are atleast 3 versions away from the minimum specified in the engine property. Unless, of course there is a bug fix that we need to take in immediately.
test/go.test.ts
Outdated
| @@ -804,7 +801,7 @@ It returns the number of bytes written and any write error encountered. | |||
| return vscode.window.showTextDocument(textDocument).then(editor => { | |||
| let promises = testCases.map(([position, expected]) => | |||
| provider.provideCompletionItems(editor.document, position, null).then(items => { | |||
| let labels = items.map(x => x.label); | |||
| let labels = items.items.map(x => x.label); | |||
There was a problem hiding this comment.
I merged another PR that fixed the tests, can you revert your changes to this file?
alexdor
force-pushed
the
feat-update-packages
branch
from
8105d18
to
8c6b47a
Compare
|
I've updated all the packages except |
|
Thanks for the PR @alexdor! Also, I see that this is your first contribution to vscode-go. Welcome & Thanks! Happy Coding! |
Updated to newer packages in order to leverage new typescript features, also it fixes some vulnerabilities that npm was reporting