fix: Fix debug debugger tasks and guide #2013
Conversation
|
|
|
@ramya-rao-a all the test that have failed here have been fixed at #2014 I can push the commits here as well if you want or I can wait until #2014 is merged and rebase this one on top of it, which one do you prefer? |
src/debugAdapter/Readme.md
Outdated
| @@ -13,6 +13,6 @@ cd vscode-go | |||
| npm install | |||
| ``` | |||
| 2. Open the `vscode-go` folder in one instance. Choose the `Launch Extension` debug target and hit F5 to launch a second instance. | |||
| 3. In the second instance, open the Go application you'd like to test against. In that instance, create a new Go debug target pointing at the program you want to debug, and add `"debugServer": 4711` in the root of the configuration. | |||
| 3. In the second instance, open the Go application you'd like to test against. In that instance, create a new Go debug target pointing at the program you want to debug, and add `"debugServer": 4712` in the root of the configuration. | |||
There was a problem hiding this comment.
Because of this https://github.com/Microsoft/vscode-go/blob/1cdd3667e957c1aa080f0b6f987771d436b9db6a/.vscode/launch.json#L21 it starts the server at 4712 not 4711
There was a problem hiding this comment.
There was a problem hiding this comment.
@alexdor The tests are fixed in the master branch. Can you rebase/merge from master?
alexdor
force-pushed
the
fix-debuger-debug
branch
from
1cdd366
to
871c6dd
Compare
|
@ramya-rao-a I've rebased my commit |
.vscode/launch.json
Outdated
| "args": [ | ||
| "--extensionDevelopmentPath=${workspaceFolder}" | ||
| ], | ||
| "args": ["--extensionDevelopmentPath=${workspaceRoot}"], |
There was a problem hiding this comment.
There was another PR that got merged to master which replaced all $workspaceRoot instances with $workspaceFolder.
I believe the net change you want here is to change the version number. Can you undo the other changes in this file?
alexdor
force-pushed
the
fix-debuger-debug
branch
from
871c6dd
to
7afe072
Compare
|
@ramya-rao-a I've done the changes that you requested above and fixed the deprecation warning from this 7afe072#diff-3090e25fed17a6bd57433c6bbadc451aL22 |
I was trying to tackle #1529 and while trying to follow the guide from https://github.com/Microsoft/vscode-go/tree/master/src/debugAdapter I faced a few errors and saw an old task that had deprecated options. This pr fixes those issues and updates the task's option according to the recent spec.