-
Notifications
You must be signed in to change notification settings - Fork 646
Conversation
Hi @dmage, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience! |
Hi @dmage, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
bb2743e
to
886627c
Compare
As I can see there is no way to use same command and same handler for all three cases (the output of |
629ad39
to
68d8a6b
Compare
Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so cool, thanks @dmage!
Just one thing, the messaging on the status item when tests are completed just say OK/FAIL. For someone just taking a look at it, its not clear what exactly is ok or not ok. :)
Instead, something like "Tests Passed/Failed" would be better. I can take care of that.
Thank you, I didn't expect you to merge this without any changes :) Please take a look at dmage@d4a9ff3 Now I think showHideTestStatus is unnecessary. There is no reason to hide test status when a tab switched. And test status should be invalidated if any file was changed (it may be a fixture, for example). |
To be honest I wanted to include this feature in the next update which I wanted to release in a day or two. Didn't know if that was enough time for you to respond to any additional refactoring comments. So I thought I'd do it myself :) Thanks for the update, that is definitely more cleaner. Feel free to send a PR, and I'll get it merged right away :) |
This is a very straightforward implementation of the testOnSave feature (#581).
I suppose it would be much better to compile sources only one time if buildOnSave, testOnSave, and coverOnSave are on:
go test -c
includes everything fromgo build
, cover is obtained from tests.Also it would be nice to have some sort of progress bar, but I have no idea where it should be placed.