Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Show test status until a file is changed #821

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Conversation

dmage
Copy link
Contributor

@dmage dmage commented Feb 26, 2017

Small addition for #810.

Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
@msftclas
Copy link

@dmage,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@dmage
Copy link
Contributor Author

dmage commented Feb 26, 2017

Ugly fix for CI: microsoft/vscode-extension-vscode#52

@ramya-rao-a
Copy link
Contributor

What does this have to do with microsoft/vscode-extension-vscode#52?

@ramya-rao-a ramya-rao-a merged commit f7be6f5 into microsoft:master Feb 27, 2017
@dmage
Copy link
Contributor Author

dmage commented Feb 27, 2017

I'm about https://travis-ci.org/Microsoft/vscode-go/builds/205602472
Tests for this PR are red without changes in vscode-extension-vscode.

@ramya-rao-a
Copy link
Contributor

All the Mac related tests were previously failing to connect to github: https://travis-ci.org/Microsoft/vscode-go/builds/205432409, so I wrongly assumed the current failure is due to the same reason.

vscode-extension-vscode hasn't been updated in months. Why do you think that the current failure 'base must be a non-empty string, or null/undefined.' is related to vscode-extension-code?

@dmage
Copy link
Contributor Author

dmage commented Feb 27, 2017

ddliu/gulp-remote-src@02953a1
This is the reason why tests will fail on Mac since yesterday.
I was able to reproduce this error on my macbook and found that vscode-extension-vscode uses empty string as a base.

@ramya-rao-a
Copy link
Contributor

Thanks @dmage, looks like your PR to vscode-extension-vscode was merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants