-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added command translations for italian #1152
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1152 +/- ##
==========================================
- Coverage 71.88% 71.88% -0.01%
==========================================
Files 260 260
Lines 11898 11922 +24
Branches 2112 2116 +4
==========================================
+ Hits 8553 8570 +17
- Misses 3222 3224 +2
- Partials 123 128 +5
Continue to review full report at Codecov.
|
I've asked on Twitter to see if someone can simply double-check your work, @Dotpys , since none of us speak Italian. 😄 While we wait on that, would you mind adding a news entry file (and do make sure to thank yourself!)? |
Oh, and could you also add the locale support to the list in the README? |
Done, hope everything is ok! 😊 |
Howdy! I plan on reviewing this over the weekend. Ciao. |
Thanks for adding the extra file changes, @Dotpys ! Now we're just waiting for someone to verify the translations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few proposed edits. Probably I am nitpicking here, but hey 😄
package.nls.it.json
Outdated
@@ -0,0 +1,49 @@ | |||
{ | |||
"python.command.python.sortImports.title": "Ordina gli import", | |||
"python.command.python.startREPL.title": "Inizia nuova REPL", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Lancia nuova REPL", or "Apri nuova REPL" probably more appropriate.
package.nls.it.json
Outdated
{ | ||
"python.command.python.sortImports.title": "Ordina gli import", | ||
"python.command.python.startREPL.title": "Inizia nuova REPL", | ||
"python.command.python.createTerminal.title": "Crea terminale", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Apri nuovo terminale" maybe?
package.nls.it.json
Outdated
"python.command.python.refactorExtractVariable.title": "Estrai variable", | ||
"python.command.python.refactorExtractMethod.title": "Estrai metodo", | ||
"python.command.python.viewTestOutput.title": "Mostra output dei test", | ||
"python.command.python.selectAndRunTestMethod.title": "Esegui metodo test ...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Esegui metodo di test ..."
package.nls.it.json
Outdated
"python.command.python.refactorExtractMethod.title": "Estrai metodo", | ||
"python.command.python.viewTestOutput.title": "Mostra output dei test", | ||
"python.command.python.selectAndRunTestMethod.title": "Esegui metodo test ...", | ||
"python.command.python.selectAndDebugTestMethod.title": "Esegui debug metodo test ...", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Esegui debug del metodo di test ..."
package.nls.it.json
Outdated
"python.command.python.selectAndRunTestMethod.title": "Esegui metodo test ...", | ||
"python.command.python.selectAndDebugTestMethod.title": "Esegui debug metodo test ...", | ||
"python.command.python.selectAndRunTestFile.title": "Esegui file di test ...", | ||
"python.command.python.runCurrentTestFile.title": "Esegui l'attuale file di test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Esegui il file di test attuale"
package.nls.it.json
Outdated
"python.command.python.execSelectionInDjangoShell.title": "Esegui selezione/riga nella shell Django", | ||
"python.command.python.goToPythonObject.title": "Vai a oggetto Python", | ||
"python.command.python.setLinter.title": "Selezione Linter", | ||
"python.command.python.enableLinting.title": "Abilita Linting", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Attiva Linting"
package.nls.it.json
Outdated
"python.command.python.setLinter.title": "Selezione Linter", | ||
"python.command.python.enableLinting.title": "Abilita Linting", | ||
"python.command.python.runLinting.title": "Esegui Linting", | ||
"python.snippet.launch.standard.label": "Python: File attuale", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Python: File corrente"
package.nls.it.json
Outdated
"python.command.python.enableLinting.title": "Abilita Linting", | ||
"python.command.python.runLinting.title": "Esegui Linting", | ||
"python.snippet.launch.standard.label": "Python: File attuale", | ||
"python.snippet.launch.standard.description": "Esegui debug di un programma Python con output predefinito", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
".. su output predefinito" rather then "con" might be more appropriate
package.nls.it.json
Outdated
"python.snippet.launch.module.label": "Python: Modulo", | ||
"python.snippet.launch.module.description": "Esegui debug modulo Python", | ||
"python.snippet.launch.terminal.label": "Python: Terminale (integrato)", | ||
"python.snippet.launch.terminal.description": "Esegui debug di un programma Python con terminale integrato", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"... nel terminale integrato"
package.nls.it.json
Outdated
"python.snippet.launch.terminal.label": "Python: Terminale (integrato)", | ||
"python.snippet.launch.terminal.description": "Esegui debug di un programma Python con terminale integrato", | ||
"python.snippet.launch.externalTerminal.label": "Python: Terminale (esterno)", | ||
"python.snippet.launch.externalTerminal.description": "Esegui debug di un programma Python con terminale esterno", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"... nel terminale esterno"
@nicolaiarocci Do the changes made by @Dotpys work for you? If so can you update your review to an approval? |
Since we're hitting RC (hopefully) today, I'm merging this now and if there any tweaks to make they can be in the April release. Thanks everyone for helping to make this happen! |
you beat me to it, damn timezones 😄 |
@nicolaiarocci we slipped by a day, so if you have a fix you need to get in then we might be able to slip it in if you get it to us by tomorrow morning on the west coast of Canada (i.e. Vancouver). |
Added translation for commands: