Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command translations for italian #1152

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Added command translations for italian #1152

merged 3 commits into from
Mar 27, 2018

Conversation

Dotpys
Copy link

@Dotpys Dotpys commented Mar 22, 2018

Added translation for commands:
ezgif com-video-to-gif

@codecov
Copy link

codecov bot commented Mar 22, 2018

Codecov Report

Merging #1152 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1152      +/-   ##
==========================================
- Coverage   71.88%   71.88%   -0.01%     
==========================================
  Files         260      260              
  Lines       11898    11922      +24     
  Branches     2112     2116       +4     
==========================================
+ Hits         8553     8570      +17     
- Misses       3222     3224       +2     
- Partials      123      128       +5
Impacted Files Coverage Δ
...rc/client/debugger/PythonProcessCallbackHandler.ts 51.64% <0%> (-1.98%) ⬇️
src/client/debugger/PythonProcess.ts 47.08% <0%> (-1.67%) ⬇️
src/client/providers/jediProxy.ts 71.36% <0%> (-0.66%) ⬇️
src/client/linters/pep8.ts 100% <0%> (ø) ⬆️
src/client/formatters/yapfFormatter.ts 95.23% <0%> (ø) ⬆️
src/client/providers/simpleRefactorProvider.ts 80.64% <0%> (ø) ⬆️
src/client/linters/flake8.ts 100% <0%> (ø) ⬆️
src/client/extension.ts 97.22% <0%> (ø) ⬆️
src/client/unittests/main.ts 50.75% <0%> (ø) ⬆️
src/client/formatters/autoPep8Formatter.ts 95% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c3ff8a...01983ae. Read the comment docs.

@brettcannon
Copy link
Member

I've asked on Twitter to see if someone can simply double-check your work, @Dotpys , since none of us speak Italian. 😄

While we wait on that, would you mind adding a news entry file (and do make sure to thank yourself!)?

@brettcannon
Copy link
Member

Oh, and could you also add the locale support to the list in the README?

@Dotpys
Copy link
Author

Dotpys commented Mar 22, 2018

Done, hope everything is ok! 😊

@nicolaiarocci
Copy link

Howdy! I plan on reviewing this over the weekend. Ciao.

@brettcannon
Copy link
Member

Thanks for adding the extra file changes, @Dotpys ! Now we're just waiting for someone to verify the translations.

@brettcannon brettcannon self-requested a review March 26, 2018 23:49
Copy link

@nicolaiarocci nicolaiarocci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few proposed edits. Probably I am nitpicking here, but hey 😄

@@ -0,0 +1,49 @@
{
"python.command.python.sortImports.title": "Ordina gli import",
"python.command.python.startREPL.title": "Inizia nuova REPL",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Lancia nuova REPL", or "Apri nuova REPL" probably more appropriate.

{
"python.command.python.sortImports.title": "Ordina gli import",
"python.command.python.startREPL.title": "Inizia nuova REPL",
"python.command.python.createTerminal.title": "Crea terminale",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Apri nuovo terminale" maybe?

"python.command.python.refactorExtractVariable.title": "Estrai variable",
"python.command.python.refactorExtractMethod.title": "Estrai metodo",
"python.command.python.viewTestOutput.title": "Mostra output dei test",
"python.command.python.selectAndRunTestMethod.title": "Esegui metodo test ...",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Esegui metodo di test ..."

"python.command.python.refactorExtractMethod.title": "Estrai metodo",
"python.command.python.viewTestOutput.title": "Mostra output dei test",
"python.command.python.selectAndRunTestMethod.title": "Esegui metodo test ...",
"python.command.python.selectAndDebugTestMethod.title": "Esegui debug metodo test ...",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Esegui debug del metodo di test ..."

"python.command.python.selectAndRunTestMethod.title": "Esegui metodo test ...",
"python.command.python.selectAndDebugTestMethod.title": "Esegui debug metodo test ...",
"python.command.python.selectAndRunTestFile.title": "Esegui file di test ...",
"python.command.python.runCurrentTestFile.title": "Esegui l'attuale file di test",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Esegui il file di test attuale"

"python.command.python.execSelectionInDjangoShell.title": "Esegui selezione/riga nella shell Django",
"python.command.python.goToPythonObject.title": "Vai a oggetto Python",
"python.command.python.setLinter.title": "Selezione Linter",
"python.command.python.enableLinting.title": "Abilita Linting",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Attiva Linting"

"python.command.python.setLinter.title": "Selezione Linter",
"python.command.python.enableLinting.title": "Abilita Linting",
"python.command.python.runLinting.title": "Esegui Linting",
"python.snippet.launch.standard.label": "Python: File attuale",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Python: File corrente"

"python.command.python.enableLinting.title": "Abilita Linting",
"python.command.python.runLinting.title": "Esegui Linting",
"python.snippet.launch.standard.label": "Python: File attuale",
"python.snippet.launch.standard.description": "Esegui debug di un programma Python con output predefinito",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

".. su output predefinito" rather then "con" might be more appropriate

"python.snippet.launch.module.label": "Python: Modulo",
"python.snippet.launch.module.description": "Esegui debug modulo Python",
"python.snippet.launch.terminal.label": "Python: Terminale (integrato)",
"python.snippet.launch.terminal.description": "Esegui debug di un programma Python con terminale integrato",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... nel terminale integrato"

"python.snippet.launch.terminal.label": "Python: Terminale (integrato)",
"python.snippet.launch.terminal.description": "Esegui debug di un programma Python con terminale integrato",
"python.snippet.launch.externalTerminal.label": "Python: Terminale (esterno)",
"python.snippet.launch.externalTerminal.description": "Esegui debug di un programma Python con terminale esterno",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... nel terminale esterno"

@brettcannon
Copy link
Member

@nicolaiarocci Do the changes made by @Dotpys work for you? If so can you update your review to an approval?

@brettcannon brettcannon added this to the March 2018 milestone Mar 27, 2018
@brettcannon brettcannon added feature-request Request for new features or functionality needs PR and removed feature-extension feature-request Request for new features or functionality labels Mar 27, 2018
@brettcannon brettcannon merged commit d29a7cc into microsoft:master Mar 27, 2018
@brettcannon
Copy link
Member

Since we're hitting RC (hopefully) today, I'm merging this now and if there any tweaks to make they can be in the April release.

Thanks everyone for helping to make this happen!

@nicolaiarocci
Copy link

you beat me to it, damn timezones 😄

@brettcannon
Copy link
Member

@nicolaiarocci we slipped by a day, so if you have a fix you need to get in then we might be able to slip it in if you get it to us by tomorrow morning on the west coast of Canada (i.e. Vancouver).

@brettcannon brettcannon mentioned this pull request May 4, 2018
5 tasks
@brettcannon brettcannon modified the milestones: March 2018, May 2018 May 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants