-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tizen support on docs #154
Conversation
@JoonghyunCho : Thanks for your contribution! The author(s) have been notified to review your proposed change. @VladislavAntonyuk |
Learn Build status updates of commit 9054cca: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
PRMerger Results
|
@myroot Please see if you want to add more about Tizen specific. Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoonghyunCho thank you for this! I just had a minor query about whether Tizen should go in with the other platforms. If we want to keep it where it is then we can proceed 👍
docs/maui/index.md
Outdated
> While there is support for Tizen (provided by Samsung) in .NET MAUI, the .NET MAUI Community Toolkit does not currently support it. | ||
## Additional platform support | ||
|
||
.NET MAUI Community Toolkit also includes Tizen support, which is provided by Samsung. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include this in the section above (Supported versions). Of course that leads me onto the next question, do we have minimum version support for platforms through Tizen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @bijington. Let's keep all platforms together.
Minimum version is 6.5 according to csproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I just tried to align with what is written on MAUI document, but I think there is no reason to separate on here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will include Tizen in the section above! :) Thanks for your suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VladislavAntonyuk That's true! The tricky part is.. Tizen 7.0 public which will be installed on the products has .net6 in it so basically to public developers 7.0 is the official version that supports .net6.
@JoonghyunCho : Thanks for your contribution! The author(s) have been notified to review your proposed change. @VladislavAntonyuk |
Learn Build status updates of commit 68bc81e: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
PRMerger Results
|
@JoonghyunCho : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 57458ef: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
PRMerger Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks for this @JoonghyunCho
@JoonghyunCho : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
This PR updates the additional platform support on the CommunityToolkit and the content links to the .NET MAUI supported versions page.
Tizen support PR CommunityToolkit/Maui#692 is planned to be merged and released likely on 08 November.