-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Renormalize line endings #468
Conversation
Docs Build status updates of commit a0b5256:
|
Hi @nschonni, appreciate all the help cleaning these issues up! 🦙❤ I'm trying to get our docs ready to release this week though. Would you mind opening a tracking issue with all the remaining items left you're looking at so we can coordinate better and minimize conflicts? I'm also not sure what happened with #462 as it looks like the main build didn't complete now? Not sure if this link will work for you though? |
Don't really think there is much left. For this one, you can also just copy the
From the branch name, I think that failure was actually from #467, which you ended up covering in #466. So when I rebased and pushed, created an empty commit, that might have tripped up the build |
Docs Build status updates of commit 29e42df:
|
@nschonni can we please resolve these conflicts? |
@Kyaa-dost I redid the commit after rebasing and repushed. You can see that it's only whitespace by looking at the ignored diff https://github.com/MicrosoftDocs/WindowsCommunityToolkitDocs/pull/468/files?diff=unified&w=1 |
Docs Build status updates of commit e469baa:
|
Fixes #
Docs for Toolkit PR #
What changes to the docs does this PR provide?
Ran
git add --renormalize .
to renormalize the line endings in the files. Looking at https://github.com/MicrosoftDocs/WindowsCommunityToolkitDocs/pull/468/files?diff=unified&w=1 should show that it's only whitespace fixups with the.gitattributes
addedPR Checklist
Please check if your PR fulfills the following requirements:
master
for new features,live
for typos/improvements)Other information