Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Renormalize line endings #468

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Mar 9, 2021

Fixes #

Docs for Toolkit PR #

What changes to the docs does this PR provide?

Ran git add --renormalize . to renormalize the line endings in the files. Looking at https://github.com/MicrosoftDocs/WindowsCommunityToolkitDocs/pull/468/files?diff=unified&w=1 should show that it's only whitespace fixups with the .gitattributes added

PR Checklist

Please check if your PR fulfills the following requirements:

  • Correctly picked the right branch to base the change off (master for new features, live for typos/improvements)
  • For new pages, used the provided template
  • For new features, added an entry in the Table of Contents
  • Ran against a spell and grammar checker
  • Contains NO breaking changes

Other information

@opbld33
Copy link

opbld33 commented Mar 9, 2021

Docs Build status updates of commit a0b5256:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/controls/wpf-winforms/WindowsXamlHost.md ⚠️Warning View Details
docs/notifications/NotificationsOverview.md ⚠️Warning View Details
docs/platform-specific/PlatformSpecificAnalyzer.md ⚠️Warning View Details
docs/controls/wpf-winforms/InkCanvas.md 💡Suggestion View Details
docs/controls/wpf-winforms/InkToolbar.md 💡Suggestion View Details
docs/controls/wpf-winforms/MediaPlayerElement.md 💡Suggestion View Details
docs/helpers/Converters.md 💡Suggestion View Details
docs/helpers/SystemInformation.md 💡Suggestion View Details
docs/index.md 💡Suggestion View Details
docs/knownissues.md 💡Suggestion View Details
.gitattributes ✅Succeeded
docs/Getting-Started.md ✅Succeeded View
docs/Nuget-Packages.md ✅Succeeded View
docs/Toolbox-Support.md ✅Succeeded View
docs/animations/AnimationSet.md ✅Succeeded View
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/ConnectedAnimations.md ✅Succeeded View
docs/animations/Expressions.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/FadeHeader.md ✅Succeeded View
docs/animations/ImplicitAnimations.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View
docs/breadcrumb/toc.yml ✅Succeeded
docs/brushes/BackdropBlurBrush.md ✅Succeeded View
docs/brushes/BackdropGammaTransferBrush.md ✅Succeeded View
docs/brushes/BackdropInvertBrush.md ✅Succeeded View
docs/brushes/BackdropSaturationBrush.md ✅Succeeded View
docs/brushes/BackdropSepiaBrush.md ✅Succeeded View
docs/brushes/ImageBlendBrush.md ✅Succeeded View
docs/brushes/RadialGradientBrush.md ✅Succeeded View
docs/controls/AdaptiveGridView.md ✅Succeeded View
docs/controls/BladeView.md ✅Succeeded View
docs/controls/CameraPreview.md ✅Succeeded View
docs/controls/Carousel.md ✅Succeeded View
docs/controls/DataGrid.md ✅Succeeded View
docs/controls/DockPanel.md ✅Succeeded View
docs/controls/DropShadowPanel.md ✅Succeeded View
docs/controls/GridSplitter.md ✅Succeeded View
docs/controls/HeaderedContentControl.md ✅Succeeded View
docs/controls/HeaderedItemsControl.md ✅Succeeded View
docs/controls/HeaderedTextBlock.md ✅Succeeded View
docs/controls/ImageEx.md ✅Succeeded View
docs/controls/InAppNotification.md ✅Succeeded View
docs/controls/InfiniteCanvas.md ✅Succeeded View

This comment lists only the first 50 files in the pull request.

docs/controls/wpf-winforms/WindowsXamlHost.md

  • Line 68, Column 5: [Warning-duplicate-alt-text] Alt text 'InitialTypeName property in Properties Window' is duplicated. Within an article, alt text must be unique.
  • Line 72, Column 5: [Warning-duplicate-alt-text] Alt text 'InitialTypeName property in Properties Window' is duplicated. Within an article, alt text must be unique.
  • Line 78, Column 5: [Warning-duplicate-alt-text] Alt text 'WindowsXamlHost control in the toolbox' is duplicated. Within an article, alt text must be unique.
  • Line 82, Column 5: [Warning-duplicate-alt-text] Alt text 'WindowsXamlHost control in the toolbox' is duplicated. Within an article, alt text must be unique.

docs/notifications/NotificationsOverview.md

  • Line 22, Column 1: [Warning-alt-text-bad-value] Alt text 'LiveTile' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/platform-specific/PlatformSpecificAnalyzer.md

  • Line 30, Column 1: [Warning-duplicate-alt-text] Alt text 'Code Analysis' is duplicated. Within an article, alt text must be unique.
  • Line 32, Column 1: [Warning-duplicate-alt-text] Alt text 'Code Analysis' is duplicated. Within an article, alt text must be unique.
  • Line 35, Column 1: [Warning-duplicate-alt-text] Alt text 'Code Analysis' is duplicated. Within an article, alt text must be unique.
  • Line 37, Column 1: [Warning-duplicate-alt-text] Alt text 'Code Analysis' is duplicated. Within an article, alt text must be unique.

docs/controls/wpf-winforms/InkCanvas.md

  • Line 26, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.
  • Line 53, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.

docs/controls/wpf-winforms/InkToolbar.md

  • Line 26, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.
  • Line 85, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.

docs/controls/wpf-winforms/MediaPlayerElement.md

  • Line 24, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.
  • Line 74, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.

docs/helpers/Converters.md

  • Line 14, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.boolnegationconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 15, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.booltoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 16, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.booltovisibilityconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 17, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.collectionvisibilityconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 18, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.doubletoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 19, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.doubletovisibilityconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 20, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.emptycollectiontoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 21, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.emptyobjecttoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 22, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.emptystringtoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 23, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.formatstringconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 23, Column 162: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.string.format?view=netframework-4.7. Otherwise, remove the view parameter.
  • Line 24, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.resourcenametoresourcestringconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 25, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.stringformatconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 25, Column 213: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.string.format?view=netframework-4.7. Otherwise, remove the view parameter.
  • Line 26, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.stringvisibilityconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 27, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.toolbarformatactiveconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 28, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.visibilitytoboolconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 155, Column 86: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.string.format?view=netframework-4.7. Otherwise, remove the view parameter.

docs/helpers/SystemInformation.md

  • Line 11, Column 5: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.helpers.systeminformation?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.

docs/index.md

  • Line 5, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'The Windows Community Toolkit is a collection of helper functions, custom controls, and app services. It simplifies and demonstrates common developer tasks building UWP apps for Windows 10.' is duplicated in 'index.md(5,14)', 'knownissues.md(4,14)'.

docs/knownissues.md

  • Line 4, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'The Windows Community Toolkit is a collection of helper functions, custom controls, and app services. It simplifies and demonstrates common developer tasks building UWP apps for Windows 10.' is duplicated in 'index.md(5,14)', 'knownissues.md(4,14)'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@michael-hawker
Copy link
Collaborator

michael-hawker commented Mar 9, 2021

Hi @nschonni, appreciate all the help cleaning these issues up! 🦙❤

I'm trying to get our docs ready to release this week though. Would you mind opening a tracking issue with all the remaining items left you're looking at so we can coordinate better and minimize conflicts?

I'm also not sure what happened with #462 as it looks like the main build didn't complete now? Not sure if this link will work for you though?

@nschonni
Copy link
Contributor Author

nschonni commented Mar 9, 2021

I'm trying to get our docs ready to release this week though. Would you mind opening a tracking issue with all the remaining items left you're looking at so we can coordinate better and minimize conflicts?

Don't really think there is much left. For this one, you can also just copy the .gitattributes and rerun the command in the PR description whenever you think it'll be easiest to land.

I'm also not sure what happened with #462 as it looks like the main build didn't complete now? Not sure if this link will work for you though?

From the branch name, I think that failure was actually from #467, which you ended up covering in #466. So when I rebased and pushed, created an empty commit, that might have tripped up the build

@opbld30
Copy link

opbld30 commented Mar 9, 2021

Docs Build status updates of commit 29e42df:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/controls/wpf-winforms/WindowsXamlHost.md ⚠️Warning View Details
docs/notifications/NotificationsOverview.md ⚠️Warning View Details
docs/controls/wpf-winforms/InkCanvas.md 💡Suggestion View Details
docs/controls/wpf-winforms/InkToolbar.md 💡Suggestion View Details
docs/controls/wpf-winforms/MediaPlayerElement.md 💡Suggestion View Details
docs/helpers/Converters.md 💡Suggestion View Details
docs/helpers/SystemInformation.md 💡Suggestion View Details
docs/index.md 💡Suggestion View Details
docs/knownissues.md 💡Suggestion View Details
.gitattributes ✅Succeeded
docs/Getting-Started.md ✅Succeeded View
docs/Nuget-Packages.md ✅Succeeded View
docs/Toolbox-Support.md ✅Succeeded View
docs/animations/AnimationSet.md ✅Succeeded View
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/ConnectedAnimations.md ✅Succeeded View
docs/animations/Expressions.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/FadeHeader.md ✅Succeeded View
docs/animations/ImplicitAnimations.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View
docs/breadcrumb/toc.yml ✅Succeeded
docs/brushes/BackdropBlurBrush.md ✅Succeeded View
docs/brushes/BackdropGammaTransferBrush.md ✅Succeeded View
docs/brushes/BackdropInvertBrush.md ✅Succeeded View
docs/brushes/BackdropSaturationBrush.md ✅Succeeded View
docs/brushes/BackdropSepiaBrush.md ✅Succeeded View
docs/brushes/ImageBlendBrush.md ✅Succeeded View
docs/brushes/RadialGradientBrush.md ✅Succeeded View
docs/controls/AdaptiveGridView.md ✅Succeeded View
docs/controls/BladeView.md ✅Succeeded View
docs/controls/CameraPreview.md ✅Succeeded View
docs/controls/Carousel.md ✅Succeeded View
docs/controls/DataGrid.md ✅Succeeded View
docs/controls/DockPanel.md ✅Succeeded View
docs/controls/DropShadowPanel.md ✅Succeeded View
docs/controls/GridSplitter.md ✅Succeeded View
docs/controls/HeaderedContentControl.md ✅Succeeded View
docs/controls/HeaderedItemsControl.md ✅Succeeded View
docs/controls/HeaderedTextBlock.md ✅Succeeded View
docs/controls/ImageEx.md ✅Succeeded View
docs/controls/InAppNotification.md ✅Succeeded View
docs/controls/InfiniteCanvas.md ✅Succeeded View
docs/controls/LayoutTransformControl.md ✅Succeeded View

This comment lists only the first 50 files in the pull request.

docs/controls/wpf-winforms/WindowsXamlHost.md

  • Line 68, Column 5: [Warning-duplicate-alt-text] Alt text 'InitialTypeName property in Properties Window' is duplicated. Within an article, alt text must be unique.
  • Line 72, Column 5: [Warning-duplicate-alt-text] Alt text 'InitialTypeName property in Properties Window' is duplicated. Within an article, alt text must be unique.
  • Line 78, Column 5: [Warning-duplicate-alt-text] Alt text 'WindowsXamlHost control in the toolbox' is duplicated. Within an article, alt text must be unique.
  • Line 82, Column 5: [Warning-duplicate-alt-text] Alt text 'WindowsXamlHost control in the toolbox' is duplicated. Within an article, alt text must be unique.

docs/notifications/NotificationsOverview.md

  • Line 22, Column 1: [Warning-alt-text-bad-value] Alt text 'LiveTile' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/controls/wpf-winforms/InkCanvas.md

  • Line 26, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.
  • Line 53, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.

docs/controls/wpf-winforms/InkToolbar.md

  • Line 26, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.
  • Line 85, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.

docs/controls/wpf-winforms/MediaPlayerElement.md

  • Line 24, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.
  • Line 74, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.

docs/helpers/Converters.md

  • Line 14, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.boolnegationconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 15, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.booltoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 16, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.booltovisibilityconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 17, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.collectionvisibilityconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 18, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.doubletoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 19, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.doubletovisibilityconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 20, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.emptycollectiontoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 21, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.emptyobjecttoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 22, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.emptystringtoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 23, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.formatstringconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 23, Column 162: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.string.format?view=netframework-4.7. Otherwise, remove the view parameter.
  • Line 24, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.resourcenametoresourcestringconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 25, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.stringformatconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 25, Column 213: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.string.format?view=netframework-4.7. Otherwise, remove the view parameter.
  • Line 26, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.stringvisibilityconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 27, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.toolbarformatactiveconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 28, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.ui.converters.visibilitytoboolconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 155, Column 86: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/system.string.format?view=netframework-4.7. Otherwise, remove the view parameter.

docs/helpers/SystemInformation.md

  • Line 11, Column 5: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/dotnet/api/microsoft.toolkit.uwp.helpers.systeminformation?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.

docs/index.md

  • Line 5, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'The Windows Community Toolkit is a collection of helper functions, custom controls, and app services. It simplifies and demonstrates common developer tasks building UWP apps for Windows 10.' is duplicated in 'index.md(5,14)', 'knownissues.md(4,14)'.

docs/knownissues.md

  • Line 4, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'The Windows Community Toolkit is a collection of helper functions, custom controls, and app services. It simplifies and demonstrates common developer tasks building UWP apps for Windows 10.' is duplicated in 'index.md(5,14)', 'knownissues.md(4,14)'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@michael-hawker michael-hawker mentioned this pull request Mar 11, 2021
5 tasks
@Kyaa-dost
Copy link
Contributor

@nschonni can we please resolve these conflicts?

@nschonni
Copy link
Contributor Author

@Kyaa-dost I redid the commit after rebasing and repushed. You can see that it's only whitespace by looking at the ignored diff https://github.com/MicrosoftDocs/WindowsCommunityToolkitDocs/pull/468/files?diff=unified&w=1

@opbld30
Copy link

opbld30 commented Mar 26, 2021

Docs Build status updates of commit e469baa:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/controls/wpf-winforms/WindowsXamlHost.md ⚠️Warning View Details
docs/notifications/NotificationsOverview.md ⚠️Warning View Details
docs/controls/wpf-winforms/InkCanvas.md 💡Suggestion View Details
docs/controls/wpf-winforms/InkToolbar.md 💡Suggestion View Details
docs/controls/wpf-winforms/MediaPlayerElement.md 💡Suggestion View Details
docs/controls/wpf-winforms/WebView.md 💡Suggestion View Details
docs/controls/wpf-winforms/WebViewCompatible.md 💡Suggestion View Details
docs/helpers/Converters.md 💡Suggestion View Details
docs/helpers/SystemInformation.md 💡Suggestion View Details
docs/index.md 💡Suggestion View Details
docs/knownissues.md 💡Suggestion View Details
.gitattributes ✅Succeeded
docs/Getting-Started.md ✅Succeeded View
docs/Nuget-Packages.md ✅Succeeded View
docs/Toolbox-Support.md ✅Succeeded View
docs/animations/AnimationSet.md ✅Succeeded View
docs/animations/Blur.md ✅Succeeded View
docs/animations/CompositionAnimations.md ✅Succeeded View
docs/animations/ConnectedAnimations.md ✅Succeeded View
docs/animations/Expressions.md ✅Succeeded View
docs/animations/Fade.md ✅Succeeded View
docs/animations/FadeHeader.md ✅Succeeded View
docs/animations/ImplicitAnimations.md ✅Succeeded View
docs/animations/Light.md ✅Succeeded View
docs/animations/Offset.md ✅Succeeded View
docs/animations/ReorderGrid.md ✅Succeeded View
docs/animations/Rotate.md ✅Succeeded View
docs/animations/Saturation.md ✅Succeeded View
docs/animations/Scale.md ✅Succeeded View
docs/breadcrumb/toc.yml ✅Succeeded
docs/brushes/BackdropBlurBrush.md ✅Succeeded View
docs/brushes/BackdropGammaTransferBrush.md ✅Succeeded View
docs/brushes/BackdropInvertBrush.md ✅Succeeded View
docs/brushes/BackdropSaturationBrush.md ✅Succeeded View
docs/brushes/BackdropSepiaBrush.md ✅Succeeded View
docs/brushes/ImageBlendBrush.md ✅Succeeded View
docs/brushes/RadialGradientBrush.md ✅Succeeded View
docs/controls/AdaptiveGridView.md ✅Succeeded View
docs/controls/BladeView.md ✅Succeeded View
docs/controls/CameraPreview.md ✅Succeeded View
docs/controls/Carousel.md ✅Succeeded View
docs/controls/DataGrid.md ✅Succeeded View
docs/controls/DockPanel.md ✅Succeeded View
docs/controls/DropShadowPanel.md ✅Succeeded View
docs/controls/GridSplitter.md ✅Succeeded View
docs/controls/HeaderedContentControl.md ✅Succeeded View
docs/controls/HeaderedItemsControl.md ✅Succeeded View
docs/controls/HeaderedTextBlock.md ✅Succeeded View
docs/controls/ImageEx.md ✅Succeeded View
docs/controls/InAppNotification.md ✅Succeeded View

This comment lists only the first 50 files in the pull request.

docs/controls/wpf-winforms/WindowsXamlHost.md

  • Line 68, Column 5: [Warning-duplicate-alt-text] Alt text 'InitialTypeName property in Properties Window' is duplicated. Within an article, alt text must be unique.
  • Line 72, Column 5: [Warning-duplicate-alt-text] Alt text 'InitialTypeName property in Properties Window' is duplicated. Within an article, alt text must be unique.
  • Line 78, Column 5: [Warning-duplicate-alt-text] Alt text 'WindowsXamlHost control in the toolbox' is duplicated. Within an article, alt text must be unique.
  • Line 82, Column 5: [Warning-duplicate-alt-text] Alt text 'WindowsXamlHost control in the toolbox' is duplicated. Within an article, alt text must be unique.
  • Line 277, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

docs/notifications/NotificationsOverview.md

  • Line 22, Column 1: [Warning-alt-text-bad-value] Alt text 'LiveTile' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

docs/controls/wpf-winforms/InkCanvas.md

  • Line 26, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.
  • Line 53, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.
  • Line 55, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

docs/controls/wpf-winforms/InkToolbar.md

  • Line 26, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.
  • Line 85, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.
  • Line 87, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

docs/controls/wpf-winforms/MediaPlayerElement.md

  • Line 24, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.
  • Line 74, Column 1: [Suggestion-duplicate-headings] Duplicate heading: 'H2 'Requirements''. Each second level heading (H2) in an article must be unique.
  • Line 76, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

docs/controls/wpf-winforms/WebView.md

  • Line 32, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.
  • Line 582, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

docs/controls/wpf-winforms/WebViewCompatible.md

  • Line 252, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

docs/helpers/Converters.md

  • Line 14, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.boolnegationconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 15, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.booltoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 16, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.booltovisibilityconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 17, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.collectionvisibilityconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 18, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.doubletoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 19, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.doubletovisibilityconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 20, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.emptycollectiontoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 21, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.emptyobjecttoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 22, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.emptystringtoobjectconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 23, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.formatstringconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 23, Column 136: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/system.string.format?view=netframework-4.7. Otherwise, remove the view parameter.
  • Line 24, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.resourcenametoresourcestringconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 25, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.stringformatconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 25, Column 187: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/system.string.format?view=netframework-4.7. Otherwise, remove the view parameter.
  • Line 26, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.stringvisibilityconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 27, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.toolbarformatactiveconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 28, Column 3: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.ui.converters.visibilitytoboolconverter?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.
  • Line 155, Column 86: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/system.string.format?view=netframework-4.7. Otherwise, remove the view parameter.

docs/helpers/SystemInformation.md

  • Line 11, Column 5: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /dotnet/api/microsoft.toolkit.uwp.helpers.systeminformation?view=uwp-toolkit-dotnet. Otherwise, remove the view parameter.

docs/index.md

  • Line 5, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'The Windows Community Toolkit is a collection of helper functions, custom controls, and app services. It simplifies and demonstrates common developer tasks building UWP apps for Windows 10.' is duplicated in 'index.md(5,14)', 'knownissues.md(4,14)'.

docs/knownissues.md

  • Line 4, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'The Windows Community Toolkit is a collection of helper functions, custom controls, and app services. It simplifies and demonstrates common developer tasks building UWP apps for Windows 10.' is duplicated in 'index.md(5,14)', 'knownissues.md(4,14)'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants