-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc for MSAL-based Azure CLI #2807
Conversation
ms.author: dbradish, jiasli | ||
manager: barbkess, yonzhan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems I can't add multiple authors, otherwise the CI warns about it:
- Line 4, Column 9: [Warning: author-not-found - See documentation]
Invalid value for author: 'dbradish-microsoft, jiasli' is not a valid GitHub ID.
- Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation]
Invalid value for 'ms.author', 'dbradish, jiasli' is not a valid Microsoft alias.
title: MSAL-based Azure CLI | Microsoft Docs | ||
description: Learn about the MSAL-based Azure CLI. | ||
author: dbradish-microsoft | ||
ms.author: dbradish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dBradish, should I put in your name or mine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiasli , use yours that way you get the GitHub Issues. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm up for discussion on any of my suggested changes and other than those, this looks good to me.
@@ -14,8 +14,6 @@ keywords: azure cli updates, azure cli notes, azure cli versions | |||
|
|||
# Azure CLI release notes | |||
|
|||
# [Current release notes](#tab/azure-cli) | |||
|
|||
## October 21, 2021 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we be adding the release notes for 2.30.0 in another PR at time of release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
@jiasli , @chasewilson , @yonzhan why do we need both the Migrate article and this new article? I feel they should be combined as they are the same subject matter. Your thoughts? |
It does appear to be duplicate information and I'm good with removing it if no one has any objections. |
We no longer uses Azure Identity, so I think https://docs.microsoft.com/en-us/cli/azure/migrate-to-azure-identity can be merged into the MSAL-based Azure CLI article. |
Co-authored-by: Chase Wilson <31453523+chasewilson@users.noreply.github.com>
# Conflicts: # docs-ref-conceptual/release-notes-azure-cli.md
# Conflicts: # docs-ref-conceptual/install-azure-cli-windows.md
# Conflicts: # docs-ref-conceptual/release-notes-azure-cli.md
Docs Build status updates of commit 4ea79f7: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Add doc for MSAL-based Azure CLI.
Azure CLI PR: