Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for MSAL-based Azure CLI #2807

Merged
merged 8 commits into from
Nov 2, 2021
Merged

Add doc for MSAL-based Azure CLI #2807

merged 8 commits into from
Nov 2, 2021

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Oct 29, 2021

Add doc for MSAL-based Azure CLI.

Azure CLI PR:

Comment on lines 5 to 6
ms.author: dbradish, jiasli
manager: barbkess, yonzhan
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I can't add multiple authors, otherwise the CI warns about it:

  • Line 4, Column 9: [Warning: author-not-found - See documentation] Invalid value for author: 'dbradish-microsoft, jiasli' is not a valid GitHub ID.
  • Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'dbradish, jiasli' is not a valid Microsoft alias.

title: MSAL-based Azure CLI | Microsoft Docs
description: Learn about the MSAL-based Azure CLI.
author: dbradish-microsoft
ms.author: dbradish
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dBradish, should I put in your name or mine?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiasli , use yours that way you get the GitHub Issues. :-)

Copy link
Contributor

@chasewilson chasewilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm up for discussion on any of my suggested changes and other than those, this looks good to me.

docs-ref-conceptual/msal-based-azure-cli.md Outdated Show resolved Hide resolved
docs-ref-conceptual/msal-based-azure-cli.md Outdated Show resolved Hide resolved
docs-ref-conceptual/msal-based-azure-cli.md Outdated Show resolved Hide resolved
docs-ref-conceptual/msal-based-azure-cli.md Outdated Show resolved Hide resolved
docs-ref-conceptual/msal-based-azure-cli.md Outdated Show resolved Hide resolved
@@ -14,8 +14,6 @@ keywords: azure cli updates, azure cli notes, azure cli versions

# Azure CLI release notes

# [Current release notes](#tab/azure-cli)

## October 21, 2021

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we be adding the release notes for 2.30.0 in another PR at time of release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@dbradish-microsoft
Copy link
Collaborator

@jiasli , @chasewilson , @yonzhan why do we need both the Migrate article and this new article? I feel they should be combined as they are the same subject matter. Your thoughts?

@chasewilson
Copy link
Contributor

@jiasli , @chasewilson , @yonzhan why do we need both the Migrate article and this new article? I feel they should be combined as they are the same subject matter. Your thoughts?

It does appear to be duplicate information and I'm good with removing it if no one has any objections.

@jiasli
Copy link
Member Author

jiasli commented Nov 1, 2021

We no longer uses Azure Identity, so I think https://docs.microsoft.com/en-us/cli/azure/migrate-to-azure-identity can be merged into the MSAL-based Azure CLI article.

jiasli and others added 3 commits November 1, 2021 10:31
Co-authored-by: Chase Wilson <31453523+chasewilson@users.noreply.github.com>
# Conflicts:
#	docs-ref-conceptual/release-notes-azure-cli.md
@MicrosoftDocs MicrosoftDocs deleted a comment from opbld32 Nov 1, 2021
@MicrosoftDocs MicrosoftDocs deleted a comment from opbld30 Nov 1, 2021
# Conflicts:
#	docs-ref-conceptual/install-azure-cli-windows.md
# Conflicts:
#	docs-ref-conceptual/release-notes-azure-cli.md
@MicrosoftDocs MicrosoftDocs deleted a comment from opbld31 Nov 2, 2021
@opbld31
Copy link

opbld31 commented Nov 2, 2021

Docs Build status updates of commit 4ea79f7:

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/TOC.yml ✅Succeeded View
docs-ref-conceptual/install-azure-cli-beta.md ✅Succeeded
docs-ref-conceptual/install-azure-cli-windows.md ✅Succeeded View
docs-ref-conceptual/install-azure-cli.md ✅Succeeded View
docs-ref-conceptual/migrate-to-azure-identity.md ✅Succeeded
docs-ref-conceptual/msal-based-azure-cli.md ✅Succeeded View
docs-ref-conceptual/release-notes-azure-cli.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@MicrosoftDocs MicrosoftDocs deleted a comment from opbld30 Nov 2, 2021
@MicrosoftDocs MicrosoftDocs deleted a comment from opbld31 Nov 2, 2021
@MicrosoftDocs MicrosoftDocs deleted a comment from opbld33 Nov 2, 2021
@MicrosoftDocs MicrosoftDocs deleted a comment from opbld33 Nov 2, 2021
@jiasli jiasli merged commit 9e55c40 into MicrosoftDocs:master Nov 2, 2021
@jiasli jiasli deleted the msal branch November 2, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants