Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 when upgrading - script should detect if the installed version is the current version #828

Closed
tommy-rk opened this issue Mar 3, 2020 · 2 comments · Fixed by #831
Closed

🚀 when upgrading - script should detect if the installed version is the current version #828

tommy-rk opened this issue Mar 3, 2020 · 2 comments · Fixed by #831
Assignees
@MiczFlor
Labels
enhancement
Milestone
2.0

Comments

@tommy-rk
Copy link

tommy-rk commented Mar 3, 2020

Feature Description

When upgrading with the installer script on Buster it already detects the installed version of RPi-Jukebox-RFID, but it doesn't know, if it is the current version and doesn't need to update at all.

How do you envision the feature to work from a users perspective?

Make updates easier.
@s-martin
Copy link
Collaborator

s-martin commented Mar 3, 2020

I agree this could be a nice enhancement.
We read already the used git commit during installation, if we save the commit number, we could compare it in future installation.

If the commit number is different, I think we can assume that the commit number coming from the repo is newer.

@s-martin s-martin mentioned this issue Mar 3, 2020
Closed
@s-martin
Copy link
Collaborator

s-martin commented Mar 3, 2020

The version information is maintained here: https://github.com/MiczFlor/RPi-Jukebox-RFID/blob/master/settings/version

This numbering is updated rarely, so currently the information is not very useful. The installer uses the latest commit from master branch, so the newest updates are used, but the version should reflect this or be dropped altogether.

An idea could be to store the git commit in the version file (maybe while keeping the major version), so this information is useful and can be used to determine, if the install script should run at all.

@MiczFlor, what do you think?

See also #829.

@s-martin s-martin mentioned this issue Mar 4, 2020
Merged
@s-martin s-martin linked a pull request Mar 4, 2020 that will close this issue
[WIP] Improve version info #831
Merged
s-martin added a commit that referenced this issue Apr 11, 2020
@s-martin @Groovylein
@MiczFlor @fredg02 @MalteHST @lovethisshit @fhaertig
fixed formatting warnings (#872)
b030ab9 
* save used git commit hash to version file (see #828)

* added first idea

* Get rid of debconf: falling back to frontend: Readline messages while installing

* Adapt for stretch dockerfile

* Added functions for logging

* Enable Logging during the installation

* Added config file information into logging

* Updated comments

* fixed flake8 warnings

* read current commit from Github

* Consolidate install scripts (#871)

* Remove duplicate chown/chmod

* Align stretch install scripts

* Remove stretch-install-spotify.sh script

* Add info about pkg installation (#879)

* Add info about pkg installation 

Fix for #818

* Update README.md

* added missing sudo

* Update Detect rfidoff function in gpio-buttons.py (#869)

* Update Detect rfidoff function in gpio-buttons.py

Adapted the RFID-Off function to the new gpio-buttons code structure. Works fine with the hardware hack for the USB-rfid reader described here:
#62

The rfidoff event is triggered when the used gpio is pulled down.

* Added Missing "Channel" to rfidoff Action

* add empty header context to spotify requests, fixes title and cover download (#884)

Co-authored-by: fhaertig <felix.haertig@ecube.de>

* Add info how to post logging info (#882)

* fixed flake8 warnings

Co-authored-by: Kiri <kiri@sockiri01.bbn.verigy.net>
Co-authored-by: Groovylein <kiriakos.antoniadis.kiri@gmail.com>
Co-authored-by: Micz Flor <micz.flor@web.de>
Co-authored-by: Fred G <fredg02@hotmail.com>
Co-authored-by: MalteHST <40899451+MalteHST@users.noreply.github.com>
Co-authored-by: lovethisshit <2253904+lovethisshit@users.noreply.github.com>
Co-authored-by: fhaertig <felix.haertig@ecube.de>
@s-martin s-martin added this to the 2.0 milestone May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiczFlor MiczFlor

Labels
enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

[WIP] Improve version info
3 participants
@tommy-rk @MiczFlor @s-martin