feat: merge array from arguments with array from config (yargs#83)

Mike111177 · Dec 20, 2017 · 806ddd6 · 806ddd6
1 parent 3087e1d
commit 806ddd6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -487,7 +487,7 @@ function parse (args, opts) {
       } else {
         // setting arguments via CLI takes precedence over
         // values within the config file.
-        if (!hasKey(argv, fullKey.split('.')) || (flags.defaulted[fullKey])) {
+        if (!hasKey(argv, fullKey.split('.')) || (flags.defaulted[fullKey]) || (flags.arrays[fullKey])) {
           setArg(fullKey, value)
         }
       }

diff --git a/test/yargs-parser.js b/test/yargs-parser.js
@@ -450,6 +450,18 @@ describe('yargs-parser', function () {
       argv.should.have.property('foo').and.deep.equal('baz')
     })
 
+    it('should combine values from config file and argv, if argv value is an array', function () {
+      var argv = parser(['--foo', 'bar'], {
+        config: ['settings'],
+        array: ['foo'],
+        default: {
+          settings: jsonPath
+        }
+      })
+
+      argv.should.have.property('foo').and.deep.equal(['bar', 'baz'])
+    })
+
     it('should use value from config file, if argv key is a boolean', function () {
       var argv = parser([], {
         config: ['settings'],