Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-501: Add support for Godot 4.3 beta1 #501

Closed
MikeSchulze opened this issue Jun 15, 2024 · 0 comments · Fixed by #502
Closed

GD-501: Add support for Godot 4.3 beta1 #501

MikeSchulze opened this issue Jun 15, 2024 · 0 comments · Fixed by #502
Assignees
@MikeSchulze
Labels
CI CI - Workflow dependencies Pull requests that update a dependency file Exclude from release nodes This issue is an internal fix only and do not report at release notes. godot related issue Its a bug by Godot engine and can't be fixed by GdUnit refactoring Mark to refactoring a implementation
Milestone
v4.3.2

Comments

@MikeSchulze
Copy link
Owner

A Task is not a bug or feature request

Description

The new beta1 version of Godot 4.3 is out and needs to be tested against GdUnit4

Acceptance criteria

add Godot 4.3.beta1 to the CI test WF, fix failing stuff
@MikeSchulze MikeSchulze self-assigned this Jun 15, 2024
@MikeSchulze MikeSchulze added refactoring Mark to refactoring a implementation godot related issue Its a bug by Godot engine and can't be fixed by GdUnit CI CI - Workflow dependencies Pull requests that update a dependency file Exclude from release nodes This issue is an internal fix only and do not report at release notes. labels Jun 15, 2024
@MikeSchulze MikeSchulze added this to the v4.3.2 milestone Jun 15, 2024
@MikeSchulze MikeSchulze changed the title Add support for Godot 4.3 beta1 GD-501: Add support for Godot 4.3 beta1 Jun 15, 2024
MikeSchulze added a commit that referenced this issue Jun 15, 2024
@MikeSchulze
GD-501: Prepare GdUnit4 for Godot 4.3.beta1
2a84b77 
# Why
see #501

# What
- added Godot 4.3.beta1 to the CI workflow
- fixed enum default value warnings
- fixed unused signal warnings
- fixed missing test-suite icon resource
- fixed failing input action tests

-
@MikeSchulze MikeSchulze mentioned this issue Jun 15, 2024
Merged
@MikeSchulze MikeSchulze linked a pull request Jun 15, 2024 that will close this issue
GD-501: Prepare GdUnit4 for Godot 4.3.beta1 #502
Merged
MikeSchulze added a commit that referenced this issue Jun 15, 2024
@MikeSchulze
GD-501: Prepare GdUnit4 for Godot 4.3.beta1
918cf69 
# Why
see #501

# What
- added Godot 4.3.beta1 to the CI workflow
- fixed enum default value warnings
- fixed unused signal warnings
- fixed missing test-suite icon resource
- fixed failing input action tests

-
MikeSchulze added a commit that referenced this issue Jun 15, 2024
@MikeSchulze
GD-501: Prepare GdUnit4 for Godot 4.3.beta1
70ffeaf 
# Why
see #501

# What
- added Godot 4.3.beta1 to the CI workflow
- fixed enum default value warnings
- fixed unused signal warnings
- fixed missing test-suite icon resource
- fixed failing input action tests

-
MikeSchulze added a commit that referenced this issue Jun 15, 2024
@MikeSchulze
GD-501: Prepare GdUnit4 for Godot 4.3.beta1
352175e 
# Why
see #501

# What
- added Godot 4.3.beta1 to the CI workflow
- fixed enum default value warnings
- fixed unused signal warnings
- fixed missing test-suite icon resource
- fixed failing input action tests

-
MikeSchulze added a commit that referenced this issue Jun 15, 2024
@MikeSchulze
GD-501: Prepare GdUnit4 for Godot 4.3.beta1
6176b39 
# Why
see #501

# What
- added Godot 4.3.beta1 to the CI workflow
- fixed enum default value warnings
- fixed unused signal warnings
- fixed missing test-suite icon resource
- fixed failing input action tests

-
MikeSchulze added a commit that referenced this issue Jun 16, 2024
@MikeSchulze
GD-501: Prepare GdUnit4 for Godot 4.3.beta1
7b796c4 
# Why
see #501

# What
- added Godot 4.3.beta1 to the CI workflow
- fixed enum default value warnings
- fixed unused signal warnings
- fixed missing test-suite icon resource
- fixed failing input action tests

-
MikeSchulze added a commit that referenced this issue Jun 16, 2024
@MikeSchulze
GD-501: Prepare GdUnit4 for Godot 4.3.beta1
fcc28d5 
# Why
see #501

# What
- added Godot 4.3.beta1 to the CI workflow
- fixed enum default value warnings
- fixed unused signal warnings
- fixed missing test-suite icon resource
- fixed failing input action tests

-
MikeSchulze added a commit that referenced this issue Jun 16, 2024
@MikeSchulze
GD-501: Prepare GdUnit4 for Godot 4.3.beta1
2fcde07 
# Why
see #501

# What
- added Godot 4.3.beta1 to the CI workflow
- fixed enum default value warnings
- fixed unused signal warnings
- fixed missing test-suite icon resource
- fixed failing input action tests

-
MikeSchulze added a commit that referenced this issue Jun 16, 2024
@MikeSchulze
GD-501: Prepare GdUnit4 for Godot 4.3.beta1
c9ab8c7 
# Why
see #501

# What
- added Godot 4.3.beta1 to the CI workflow
- fixed enum default value warnings
- fixed unused signal warnings
- fixed missing test-suite icon resource
- fixed failing input action tests

-
MikeSchulze added a commit that referenced this issue Jun 16, 2024
@MikeSchulze
GD-501: Prepare GdUnit4 for Godot 4.3.beta1
93737dc 
# Why
see #501

# What
- added Godot 4.3.beta1 to the CI workflow
- fixed enum default value warnings
- fixed unused signal warnings
- fixed missing test-suite icon resource
- fixed failing input action tests

-
MikeSchulze added a commit that referenced this issue Jun 16, 2024
@MikeSchulze
GD-501: Prepare GdUnit4 for Godot 4.3.beta1 (#502)
edb26a8 
# Why
see #501

# What
- added Godot 4.3.beta1 to the CI workflow
- fixed enum default value warnings
- fixed unused signal warnings
- fixed missing test-suite icon resource
- fixed failing input action tests
- use typed values in GdObject to avoid bug
godotengine/godot#93193
- add `TYPE_PACKED_VECTOR4_ARRAY` constant to be used on Godot versions
less than 4.3 (is introduced with beta1)
@github-project-automation github-project-automation bot moved this to Done in GdUnit4 Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeSchulze MikeSchulze

Labels
CI CI - Workflow dependencies Pull requests that update a dependency file Exclude from release nodes This issue is an internal fix only and do not report at release notes. godot related issue Its a bug by Godot engine and can't be fixed by GdUnit refactoring Mark to refactoring a implementation
Projects
GdUnit4
Status: Done
Milestone
v4.3.2
Development

Successfully merging a pull request may close this issue.

GD-501: Prepare GdUnit4 for Godot 4.3.beta1 MikeSchulze/gdUnit4
1 participant
@MikeSchulze