Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-573: Inspector: double-click, inherited tests not jump to the right script #573

Closed
MikeSchulze opened this issue Sep 19, 2024 · 0 comments · Fixed by #574
Closed

GD-573: Inspector: double-click, inherited tests not jump to the right script #573

MikeSchulze opened this issue Sep 19, 2024 · 0 comments · Fixed by #574
Assignees
Labels
bug Something isn't working
Milestone

Comments

@MikeSchulze
Copy link
Owner

The used GdUnit4 version

4.3.4 (Latest Release)

The used Godot version

v4.4.dev2.official [97ef3c837]

Operating System

All

Describe the bug

I am running a test suite that inherits from another test suite, the inspector shows all tests.
When I double-click on the tests, it always jumps to the main test suite, but should jump to the test suite in which the test is defined.

Steps to Reproduce

Create an inherited test suite.

extends ExtendedTest

func test_foo3() -> void:
	pass
class_name ExtendedTest
extends BaseTest


func before_test() -> void:
	pass


func after_test() -> void:
	pass


func test_foo2() -> void:
	pass
class_name BaseTest
extends GdUnitTestSuite


func before() -> void:
	pass


func after() -> void:
	pass


func before_test() -> void:
	pass


func after_test() -> void:
	pass


func test_foo1() -> void:
	pass

Double-click on test-foo1 jumps to the wrong script, it should jump to BaseTest
image

Minimal reproduction project

No response

@MikeSchulze MikeSchulze added the bug Something isn't working label Sep 19, 2024
@MikeSchulze MikeSchulze self-assigned this Sep 19, 2024
@MikeSchulze MikeSchulze added this to the v4.4.0 milestone Sep 19, 2024
@MikeSchulze MikeSchulze changed the title GD-XXX: Inspector: double-click, inherited tests not jump to the right script GD-573: Inspector: double-click, inherited tests not jump to the right script Sep 19, 2024
MikeSchulze added a commit that referenced this issue Sep 19, 2024
…ight script

# Why
see #573

# What
- use the `script_path` provided by the test case and enrich the inspector item with this meta data `META_SCRIPT_PATH`
- use the `META_SCRIPT_PATH` on select event to jump to the script where the test are located
MikeSchulze added a commit that referenced this issue Sep 19, 2024
…the script where the test are located (#574)

# Why
see #573

# What
- use the `script_path` provided by the test case and enrich the
inspector item with this metadata `META_SCRIPT_PATH`
- use the `META_SCRIPT_PATH` on select event to jump to the script where
the test are located
@github-project-automation github-project-automation bot moved this to Done in GdUnit4 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
1 participant