Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-164: Extend array assert by same validation functions #180

Merged
merged 6 commits into from
May 15, 2023
Merged

GD-164: Extend array assert by same validation functions #180

merged 6 commits into from
May 15, 2023

Conversation

MikeSchulze
Copy link
Owner

@MikeSchulze MikeSchulze commented May 13, 2023 •
edited
Loading

Why

We want to compare array elements by object reference.

What

  • assert_array now supports all array types
  • added verifications
    • is_same
    • is_not_same
    • contains_same
    • contains_same_exactly
    • contains_same_exactly_in_any_order
    • not_contains_same
  • improve the failure messages by printing typed arrays
  • moved all array util functions into new class GdArrayTools
  • small cleanups

@MikeSchulze
GD-164: Extend array assert by same validation functions
1f4a7b3 
# Why
We want to compare array elements by object reference.

# What
- assert_array now supports all array types
- added new ..same verifications
- improve the failure messages by printing typed arrays
- small cleanups
@MikeSchulze MikeSchulze self-assigned this May 13, 2023
@MikeSchulze MikeSchulze linked an issue May 13, 2023 that may be closed by this pull request
GD-164: Extend the array and dictionary asserts by contains_same.. verification functions to handle compare objects by reference #164
Closed
@MikeSchulze MikeSchulze merged commit a0b87d2 into master May 15, 2023
@MikeSchulze MikeSchulze deleted the GD-164 branch May 15, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MikeSchulze MikeSchulze

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@MikeSchulze