GD-221: Fix GdUnit Inspector button bar run status issues when a scene is open #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why The button bar did not adjust the execution state when the test was running and a scene was open in the editor. # What There was an error in handling the current status of the test execution. We perform a periodic `check_test_run_stopped_manually` to ensure that we eventually stop when the test is manually stopped. With this check, we test for `_is_running==true`, but the status was set to true too early. - set status _is_running is now only set to true when the testrunner is started and not before. - fix warning `unused_parameter` at SceneRunner#set_property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The button bar did not adjust the execution state when the test was running and a scene was open in the editor.
What
There was an error in handling the current status of the test execution. We perform a periodic
check_test_run_stopped_manuallyto ensure that we eventually stop when the test is manually stopped. With this check, we test for_is_running==true, but the status was set to true too early.unused_parameterat SceneRunner#set_property