GD-233: Fix font loading error on linux systems #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why We see an error `res://addons/gdUnit4/src/ui/GdUnitFonts.gd:38 - Invalid set index 'font_data' (on base: 'FontFile') with value of type 'FontFile'.` on linux systems when activating the plugin # What The property `font_data` was removed and the error was just ignored. - Rewrite the font loader by load the font and duplicate and set the new font size. - Renamed to better related name - Add test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We see an error
res://addons/gdUnit4/src/ui/GdUnitFonts.gd:38 - Invalid set index 'font_data' (on base: 'FontFile') with value of type 'FontFile'.on linux systems when activating the pluginWhat
The property
font_datawas removed and the error was just ignored.