Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-254: Fix inspector icon scaling #253

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Conversation

MikeSchulze
Copy link
Owner

@MikeSchulze MikeSchulze commented Sep 13, 2023

Orignal PR created by bitbrainimage

Why

On 4K monitors especially, the icons are too small and do not scale properly with the Godot editor.

What

  • Updated the inspector image import settings to ensure icons now are displayed correctly by set editor/scale_with_editor_scale=true
  • Fix tree item icons by replace the manual scaling by setting scaling property theme_override_constants/icon_max_width=16x<scale_factor>

before
image
after
image

@MikeSchulze MikeSchulze self-assigned this Sep 13, 2023
@MikeSchulze MikeSchulze linked an issue Sep 13, 2023 that may be closed by this pull request
@MikeSchulze MikeSchulze changed the title Bitbrain fix icon scaling GD-254: Fix inspector icon scaling Sep 13, 2023
@MikeSchulze
Copy link
Owner Author

@bitbrain can you verify if this fix working on your 4k monitor?

@bitbrain
Copy link
Contributor

Screenshot 2023-09-14 183001

beautiful, works like a charm!

@MikeSchulze MikeSchulze merged commit 3d04fc3 into master Sep 14, 2023
@MikeSchulze MikeSchulze deleted the bitbrain-fix-icon-scaling branch September 14, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD-254: inspector icons not scale on 4k screens
2 participants