Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup script erros #276

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Cleanup script erros #276

merged 4 commits into from
Oct 24, 2023

Conversation

MikeSchulze
Copy link
Owner

@MikeSchulze MikeSchulze commented Oct 23, 2023 •
edited
Loading

Why

GdUnit4 contains some script errors such as:

  • redundant awaits
  • shadowing an already-declared function at line xxx

What

  • Fix error messages to rid the log of script errors generated by the GdUnit4 framework
  • Fix bug in the new executor, do not execute skipped test cases
  • Disable the leaked instance gurad for now, it let the engine randomly crash at exit and needs an deeper investigate to fix

@MikeSchulze MikeSchulze marked this pull request as ready for review October 24, 2023 15:54
@MikeSchulze MikeSchulze self-assigned this Oct 24, 2023
@MikeSchulze MikeSchulze added this to the V4.2.0 milestone Oct 24, 2023
@MikeSchulze MikeSchulze merged commit f9986be into master Oct 24, 2023
@MikeSchulze MikeSchulze deleted the fix_script_errors branch October 24, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MikeSchulze MikeSchulze

Labels
None yet
Projects
None yet
Milestone
V4.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@MikeSchulze