Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-368: Fix runtime test parameter set resolving #369

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

MikeSchulze
Copy link
Owner

@MikeSchulze MikeSchulze commented Mar 12, 2024

Why

There are a couple of issues pop up by introducing the dynamic parameter set resolving.

  • the parameters were resolved to early and get not the before_test stage into account
  • the parameterized test was called with the values from the test set, but the test set itself was not reset and results into unnecessarily re-instantiate of test arguments

What

  • use test parameter set resolver to get test parameter set
  • optimized to detect, load and use static property sets for better test execution performance
  • do resolve parameter sets that use runtime variables after each before_test call
  • do fix the unnecessarily re-instantiate of test arguments we are calling the test function with an additional empty array to "override" the test_parameters arguments default
  • fix invalid orphan detection when the properties are copied to extract the test properties

do not cache the parameter set, do fresh extract at current object state
@MikeSchulze MikeSchulze force-pushed the GD-368 branch 3 times, most recently from 47d9873 to 7255c97 Compare March 14, 2024 13:19
@MikeSchulze MikeSchulze changed the title GD-368: Fix dynamic parameter set resolving GD-368: Fix runtime test parameter set resolving Mar 14, 2024
@MikeSchulze MikeSchulze merged commit 678c48c into master Mar 14, 2024
@MikeSchulze MikeSchulze deleted the GD-368 branch March 14, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD-368: Dynamic test parameter resolving do unnecessarily re-instantiate of test arguments
1 participant