GD-389: The inheritance of a base test class leads to an incorrect test case list. #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st case list. # Why #389 # What When the scanner is building the function descriptors, it was using the list of tests and adding the `before` function to scan. The list to scan was not a copy and results into side effect of the original test list. Fixed by using a copy before adding the `before` function Extended the existing test coverage for test suite inheritance to include the `before` on the base test suite.
MikeSchulze
force-pushed
the
GD-389
branch
5 times, most recently
from
a5c7832 to
b10b908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#389
What
When the scanner is building the function descriptors, it was using the list of tests and adding the
beforefunction to scan. The list to scan was not a copy and results into side effect of the original test list. Fixed by using a copy before adding thebeforefunction extended the existing test coverage for test suite inheritance to include thebeforeon the base test suite.