GD-401: Support action input events on scene runner #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #401
(as suggested on Discord)
Using generic action events is better as unit tests don't get tied to a specific key in the project for any given action. Furthermore, it also support actions that only have controller inputs.
What
Adds methods for a scene runner to also support action events.
Oddly though, I'm not getting any luck in implementing unit testing for this feature on the addon's tests. This works as expected on the tests in my project, but for some reasonEDIT: Fixed by @MikeSchulze ❤️Input.is_action_pressed
AFAICT never returns true on the unit tests. I also see there is a testtest_simulate_keypressed_as_action
doing something similar and is also failing though.