Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-413: Allow to spy on a class with enum as constructor argument #412

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

MikeSchulze
Copy link
Owner

Why

The spy runs into an error when try to spy on an instance where has an Enum argument in the constructor.

What

Fixed the spy builder by evaluate the arg_type is an Enum and set the respective argument type.

@MikeSchulze MikeSchulze self-assigned this Apr 24, 2024
@MikeSchulze MikeSchulze linked an issue Apr 25, 2024 that may be closed by this pull request
# Why
The spy runs into an error when try to spy on an instance where has an enum argument in the constructor.

# What
Fixed the spy builder by evaluate the arg_type is an enum and set the respective argument type.
@MikeSchulze MikeSchulze changed the title GD-xxx: Allow to spy on a class with enum as constructor argument GD-413: Allow to spy on a class with enum as constructor argument Apr 25, 2024
@MikeSchulze MikeSchulze merged commit 5dfc5ae into master Apr 25, 2024
@MikeSchulze MikeSchulze deleted the spy_fix branch April 25, 2024 05:32
@MikeSchulze
Copy link
Owner Author

Restore for test reason

@MikeSchulze MikeSchulze restored the spy_fix branch April 26, 2024 06:29
@MikeSchulze MikeSchulze deleted the spy_fix branch April 26, 2024 06:29
@MikeSchulze MikeSchulze added the bug Something isn't working label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD-413: Classes with enum in their constructor cannot be spied on
1 participant