Simplify .gitattributes
#424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great, thank you yes, that makes it much easier 👍 |
MikeSchulze
changed the title
.gitattributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I can't tell for sure but it seems like
.runsettings*and.gdlintrcpaths were included in the release by mistake since the.gitattributesis an excluded list.The current
.gitattributesstructure looks difficult to maintain. If.runsettings*and/or.gdlintrcshould be kept in the final release, this PR can easily be updated to include them explicitly.What
I flipped the
.gitattributesaround to be an includes list by excluding everything first. This approach should keep it more maintainable as you may add other files to the project later that are not needed in the final release.This is testable by running this command against this branch:
git archive --format=tar improve-gitattribute | gzip > <replace-this-with-a-path>