GD-471: Support UTF8 characters on reporting failure messages
#473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why The test messages losing UTF8 characters during reporting. This results for converting UTF8 strings via `to_utf8_buffer` and `get_string_from_utf8` # What fixes by replace `get_string_from_utf8` and `to_utf8_buffer` by the utf8 derivate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The test messages losing UTF8 characters during reporting. This results for converting UTF8 strings via
to_utf8_bufferandget_string_from_utf8What
fixes by replace
get_string_from_utf8andto_utf8_bufferby the utf8 derivate