GD-483: Provide a hotfix crash at exit on macOS
#484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Why With version 4.3.0 the plugin exit results into a crash during releasing the owned objects. # What - fix freeing components by using `queue_free` as the official documentation suggested for `remove_control_from_docks` - do `call_deferred` to remove the gdunit server component, where was the root cause of the crash - Finally, we're freeing all other resources deferred to avoid singletons to freed before the other resources has queued freed
MikeSchulze
force-pushed
the
GD-483
branch
2 times, most recently
from
33d715b to
115b995
Compare
MikeSchulze
changed the title
macOSmacOS
MikeSchulze
changed the title
macOSmacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
With version 4.3.0 the plugin exit results into a crash during releasing the owned objects.
What
queue_freeonmacOSas the official documentation suggested forremove_control_from_docksbut it results now in a lot of memory leaks. (will create a Godot issue)call_deferredto remove the gdunit server component, where was the root cause of the crashfixes temporary
godotengine/godot#92727