Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-491: Fix Godot editor crash for Linux systems at exit #493

Merged
merged 1 commit into from
Jun 6, 2024
Merged

GD-491: Fix Godot editor crash for Linux systems at exit #493

merged 1 commit into from
Jun 6, 2024

Conversation

MikeSchulze
Copy link
Owner

@MikeSchulze MikeSchulze commented Jun 6, 2024 •
edited
Loading

Why

The Godot editor crashes if the GdUnit4 plugin enabled at exit.

What

  • Extend the hotfix to run also on Linux systems
  • Does not execute the plugin code if the project has the gdunit4 plugin enabled but is running in a test environment. This prevents the loading of UI components that are not required if the Godot program is executed without editor mode.
  • Does not execute the scheduled test discovery when you run the cmd tool to avoid overlaps during test execution.

@MikeSchulze MikeSchulze self-assigned this Jun 6, 2024
@MikeSchulze MikeSchulze added bug Something isn't working blocker This issue blocks the user to use GdUnit labels Jun 6, 2024
@MikeSchulze MikeSchulze linked an issue Jun 6, 2024 that may be closed by this pull request
GD-491: segmentation fault when closing godot editor #492
Closed
@MikeSchulze MikeSchulze changed the title GD-491: Fix Godot editor crash for Linux systems GD-491: Fix Godot editor crash for Linux systems at exit Jun 6, 2024
@MikeSchulze MikeSchulze force-pushed the GD-491 branch 7 times, most recently from 11fd4d3 to 93254a6 Compare June 6, 2024 11:48
@MikeSchulze
GD-491: Fix Godot editor crash for Linux systems
7f5f5b5 
# Why
The Godot editor crashes if the GdUnit4 plugin enabled at exit.

# What
Extend the hotfix to run also on Linux systems
@MikeSchulze MikeSchulze merged commit 11a1e24 into master Jun 6, 2024
@MikeSchulze MikeSchulze deleted the GD-491 branch June 6, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MikeSchulze MikeSchulze

Labels
blocker This issue blocks the user to use GdUnit bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GD-491: segmentation fault when closing godot editor
1 participant
@MikeSchulze