-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve settings UI #534
Improve settings UI #534
Conversation
Hello, thank you for your contribution to this project. Please be so kind and create another refactoring ticket detailing what you want to achieve and link it to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked the changes and looks good.
A have only find minor things, please check my comments.
In addition, the actual dialog size can be shrinking because the properties are now more compact and well sized.
I tried with using reset_size()
after component creation but without success, maybe you can fix this too.
Great Job, Thanks
8eba13b
to
95adc9f
Compare
I made the refactoring tickets, I'll take some screenshots and attach them later today.
Yeah, I ran into that too :(. It seems that no matter what I do, the actual dialogue size won't budge. I don't really understand the way Godot windows work, so I had little luck getting it to do what I want. I tried changing the size in the saved scene, but that value is apparently just completely ignored. The thing that displays on my screen has a completely different shape than what is shown in the 2D editor preview. |
* Improve readability for strings that were unclear / confusing * Don't add wording which is obvious from the UI itself and identical across many settings (such as "If set then ...", "Sets ...", "Enable/disable ...") * Use imperative mood consistently * Don't add unncessary punctuation * Optimise strings for compactness where possible
95adc9f
to
758b2a6
Compare
Great job, thanks for contribution to the project. |
Hi, this PR improves the settings dialogue UI, making it significantly more compact, and IMHO, also easier to understand and nicer to look at.
Before:
After:
The changes are split into three commits
I did not make any changes to the settings themselves, everything is as it was before and split across tabs in the same way. I did a full test suite run locally, and everything works aside from the C# tests, which I did not run, as I'm not using Godot Mono.