Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-544: Add Spy support for Callable #545

Merged
merged 1 commit into from
Jul 12, 2024
Merged

GD-544: Add Spy support for Callable #545

merged 1 commit into from
Jul 12, 2024

Conversation

MikeSchulze
Copy link
Owner

@MikeSchulze MikeSchulze commented Jul 11, 2024

Why

see #544

What

  • cleanup parser
    • removed extract_source_code, it was only used in tests
  • add support to spy on Callable
  • supports to spy on Callable on all functions exclusive callv and call_deferred
    call and call_deferred are not possible to stub because of interface conflicts between Callable and Object

@MikeSchulze MikeSchulze added the enhancement New feature or request label Jul 11, 2024
@MikeSchulze MikeSchulze self-assigned this Jul 11, 2024
@MikeSchulze MikeSchulze linked an issue Jul 11, 2024 that may be closed by this pull request
@MikeSchulze MikeSchulze force-pushed the GD-544 branch 2 times, most recently from 14cb440 to 17cf157 Compare July 11, 2024 13:53
@MikeSchulze MikeSchulze changed the title GD-544: Add support for Spy/Mock on callables GD-544: Add Spy/Mock support for Callable Jul 11, 2024
@MikeSchulze MikeSchulze marked this pull request as draft July 11, 2024 13:54
@MikeSchulze MikeSchulze force-pushed the GD-544 branch 15 times, most recently from 28d3dd1 to ffe75ba Compare July 12, 2024 11:04
# Why
see #544

# What
- cleanup parser
  - removed `extract_source_code`, it was only used in tests
- add support to spy on `Callable`
@MikeSchulze MikeSchulze changed the title GD-544: Add Spy/Mock support for Callable GD-544: Add Spy support for Callable Jul 12, 2024
@MikeSchulze MikeSchulze marked this pull request as ready for review July 12, 2024 11:31
@MikeSchulze MikeSchulze merged commit fac168f into master Jul 12, 2024
@MikeSchulze MikeSchulze deleted the GD-544 branch July 12, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD-544: Spies (and mocks?) should support Callables
1 participant