GD-546: Allow to test un-typed values by assert_that
#547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeSchulze
force-pushed
the
GD-546
branch
2 times, most recently
from
b8377eb to
f7f05c2
Compare
# Why see #546 # What - do allow all Variant types for `is_equal` and `is_not_equal` when using the untyped `assert_that` - changed the fixed typed `is_equal` and `is_not_equal` to accept Variant type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
see #546
What
is_equalandis_not_equalwhen using the un-typedassert_thatis_equalandis_not_equalto accept Variant type