Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StaticVectors.Values to replace StaticArrays.SVector in Cell #20

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Use StaticVectors.Values to replace StaticArrays.SVector in Cell #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f66aa7c
Add StaticVectors.jl to deps
singularitti Oct 7, 2023
92834f2
Use `StaticVectors.Values` to replace `StaticArrays.SVector` in `Cell`
singularitti Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ version = "0.3.2"
[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
StaticVectors = "20fadf95-9e3d-483c-97cd-cab2760e7998"
StructEquality = "6ec83bb0-ed9f-11e9-3b4c-2b04cb4e219c"

[compat]
Expand Down
5 changes: 3 additions & 2 deletions src/cell.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using StaticArrays: SVector, FieldVector
using StaticVectors: Values
using StructEquality: @struct_hash_equal_isequal

export ReducedCoordinates, CrystalCoordinates, Cell, natoms, atomtypes
Expand All @@ -13,8 +14,8 @@ const CrystalCoordinates = ReducedCoordinates
abstract type AbstractCell end
@struct_hash_equal_isequal struct Cell{N,L,P,T} <: AbstractCell
lattice::Lattice{L}
positions::SVector{N,ReducedCoordinates{P}}
atoms::SVector{N,T}
positions::Values{N,ReducedCoordinates{P}}
atoms::Values{N,T}
end
"""
Cell(lattice, positions, atoms)
Expand Down
Loading