Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOPY-74 #564

Merged
merged 44 commits into from
Jun 7, 2023
Merged

GEOPY-74 #564

merged 44 commits into from
Jun 7, 2023

Conversation

domfournier
Copy link
Contributor

@domfournier domfournier commented May 16, 2023

GEOPY-74 - Fork the latest Simpeg development based on simpeg>=0.18

domfournier and others added 30 commits May 5, 2023 11:18
# Conflicts:
#	conda-py-3.10-lock.yml
#	conda-py-3.9-lock.yml
#	environments/conda-py-3.10-linux-64-dev.lock.yml
#	environments/conda-py-3.10-linux-64.lock.yml
#	environments/conda-py-3.10-osx-64-dev.lock.yml
#	environments/conda-py-3.10-osx-64.lock.yml
#	environments/conda-py-3.10-win-64-dev.lock.yml
#	environments/conda-py-3.10-win-64.lock.yml
#	environments/conda-py-3.9-linux-64-dev.lock.yml
#	environments/conda-py-3.9-linux-64.lock.yml
#	environments/conda-py-3.9-osx-64-dev.lock.yml
#	environments/conda-py-3.9-osx-64.lock.yml
#	environments/conda-py-3.9-win-64-dev.lock.yml
#	environments/conda-py-3.9-win-64.lock.yml
# Conflicts:
#	conda-py-3.10-lock.yml
#	conda-py-3.9-lock.yml
#	environments/conda-py-3.10-linux-64-dev.lock.yml
#	environments/conda-py-3.10-linux-64.lock.yml
#	environments/conda-py-3.10-osx-64-dev.lock.yml
#	environments/conda-py-3.10-osx-64.lock.yml
#	environments/conda-py-3.10-win-64-dev.lock.yml
#	environments/conda-py-3.10-win-64.lock.yml
#	environments/conda-py-3.9-linux-64-dev.lock.yml
#	environments/conda-py-3.9-linux-64.lock.yml
#	environments/conda-py-3.9-osx-64-dev.lock.yml
#	environments/conda-py-3.9-osx-64.lock.yml
#	environments/conda-py-3.9-win-64-dev.lock.yml
#	environments/conda-py-3.9-win-64.lock.yml
# Conflicts:
#	geoapps/inversion/electricals/direct_current/two_dimensions/constants.py
Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Just a couple comments to look at

geoapps/inversion/driver.py Outdated Show resolved Hide resolved
geoapps/inversion/electricals/params.py Show resolved Hide resolved
benk-mira
benk-mira previously approved these changes Jun 7, 2023
Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the updates!

# Conflicts:
#	conda-py-3.10-lock.yml
#	conda-py-3.9-lock.yml
#	environments/conda-py-3.10-linux-64-dev.lock.yml
#	environments/conda-py-3.10-linux-64.lock.yml
#	environments/conda-py-3.10-osx-64-dev.lock.yml
#	environments/conda-py-3.10-osx-64.lock.yml
#	environments/conda-py-3.10-win-64-dev.lock.yml
#	environments/conda-py-3.10-win-64.lock.yml
#	environments/conda-py-3.9-linux-64-dev.lock.yml
#	environments/conda-py-3.9-linux-64.lock.yml
#	environments/conda-py-3.9-osx-64-dev.lock.yml
#	environments/conda-py-3.9-osx-64.lock.yml
#	environments/conda-py-3.9-win-64-dev.lock.yml
#	environments/conda-py-3.9-win-64.lock.yml
@domfournier domfournier merged commit 96575c4 into develop Jun 7, 2023
@domfournier domfournier deleted the GEOPY-74 branch June 7, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants